Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Side by Side Diff: BUILD.gn

Issue 1299963002: Extern in .cpp files is a code smell. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 6
7 pdf_use_skia = false 7 pdf_use_skia = false
8 8
9 declare_args() { 9 declare_args() {
10 # On Android there's no system FreeType. On Windows and Mac, only a few 10 # On Android there's no system FreeType. On Windows and Mac, only a few
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 static_library("fpdftext") { 316 static_library("fpdftext") {
317 sources = [ 317 sources = [
318 "core/include/fpdftext/fpdf_text.h", 318 "core/include/fpdftext/fpdf_text.h",
319 "core/src/fpdftext/fpdf_text.cpp", 319 "core/src/fpdftext/fpdf_text.cpp",
320 "core/src/fpdftext/fpdf_text_int.cpp", 320 "core/src/fpdftext/fpdf_text_int.cpp",
321 "core/src/fpdftext/fpdf_text_search.cpp", 321 "core/src/fpdftext/fpdf_text_search.cpp",
322 "core/src/fpdftext/text_int.h", 322 "core/src/fpdftext/text_int.h",
323 "core/src/fpdftext/txtproc.h", 323 "core/src/fpdftext/txtproc.h",
324 "core/src/fpdftext/unicodenormalization.cpp", 324 "core/src/fpdftext/unicodenormalization.cpp",
325 "core/src/fpdftext/unicodenormalizationdata.cpp", 325 "core/src/fpdftext/unicodenormalizationdata.cpp",
326 "core/src/fpdftext/unicodenormalizationdata.h",
326 ] 327 ]
327 configs -= [ "//build/config/compiler:chromium_code" ] 328 configs -= [ "//build/config/compiler:chromium_code" ]
328 configs += [ 329 configs += [
329 ":pdfium_config", 330 ":pdfium_config",
330 "//build/config/compiler:no_chromium_code", 331 "//build/config/compiler:no_chromium_code",
331 ] 332 ]
332 } 333 }
333 334
334 static_library("fxcodec") { 335 static_library("fxcodec") {
335 deps = [ 336 deps = [
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 "core/src/fxge/apple/apple_int.h", 470 "core/src/fxge/apple/apple_int.h",
470 "core/src/fxge/apple/fx_apple_platform.cpp", 471 "core/src/fxge/apple/fx_apple_platform.cpp",
471 "core/src/fxge/apple/fx_mac_imp.cpp", 472 "core/src/fxge/apple/fx_mac_imp.cpp",
472 "core/src/fxge/apple/fx_quartz_device.cpp", 473 "core/src/fxge/apple/fx_quartz_device.cpp",
473 "core/src/fxge/dib/dib_int.h", 474 "core/src/fxge/dib/dib_int.h",
474 "core/src/fxge/dib/fx_dib_composite.cpp", 475 "core/src/fxge/dib/fx_dib_composite.cpp",
475 "core/src/fxge/dib/fx_dib_convert.cpp", 476 "core/src/fxge/dib/fx_dib_convert.cpp",
476 "core/src/fxge/dib/fx_dib_engine.cpp", 477 "core/src/fxge/dib/fx_dib_engine.cpp",
477 "core/src/fxge/dib/fx_dib_main.cpp", 478 "core/src/fxge/dib/fx_dib_main.cpp",
478 "core/src/fxge/dib/fx_dib_transform.cpp", 479 "core/src/fxge/dib/fx_dib_transform.cpp",
480 "core/src/fxge/fontdata/chromefontdata/chromefontdata.h",
479 "core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c", 481 "core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c",
480 "core/src/fxge/fontdata/chromefontdata/FoxitFixed.c", 482 "core/src/fxge/fontdata/chromefontdata/FoxitFixed.c",
481 "core/src/fxge/fontdata/chromefontdata/FoxitFixedBold.c", 483 "core/src/fxge/fontdata/chromefontdata/FoxitFixedBold.c",
482 "core/src/fxge/fontdata/chromefontdata/FoxitFixedBoldItalic.c", 484 "core/src/fxge/fontdata/chromefontdata/FoxitFixedBoldItalic.c",
483 "core/src/fxge/fontdata/chromefontdata/FoxitFixedItalic.c", 485 "core/src/fxge/fontdata/chromefontdata/FoxitFixedItalic.c",
484 "core/src/fxge/fontdata/chromefontdata/FoxitSans.c", 486 "core/src/fxge/fontdata/chromefontdata/FoxitSans.c",
485 "core/src/fxge/fontdata/chromefontdata/FoxitSansBold.c", 487 "core/src/fxge/fontdata/chromefontdata/FoxitSansBold.c",
486 "core/src/fxge/fontdata/chromefontdata/FoxitSansBoldItalic.c", 488 "core/src/fxge/fontdata/chromefontdata/FoxitSansBoldItalic.c",
487 "core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c", 489 "core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c",
488 "core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c", 490 "core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c",
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
784 "//v8", 786 "//v8",
785 "//v8/include", 787 "//v8/include",
786 "." 788 "."
787 ] 789 ]
788 configs -= [ "//build/config/compiler:chromium_code" ] 790 configs -= [ "//build/config/compiler:chromium_code" ]
789 configs += [ 791 configs += [
790 ":pdfium_config", 792 ":pdfium_config",
791 "//build/config/compiler:no_chromium_code", 793 "//build/config/compiler:no_chromium_code",
792 ] 794 ]
793 } 795 }
OLDNEW
« no previous file with comments | « no previous file | core/include/fpdfapi/fpdf_parser.h » ('j') | core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698