Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1299943002: cast SK_ARRAY_COUNT to make it sign agnostic (Closed)

Created:
5 years, 4 months ago by caryclark
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

cast SK_ARRAY_COUNT to make it sign agnostic By adding a cast to SK_ARRAY_COUNT, the compiler treats the compile-time value as if it were a const int, and like regular numbers, permits it to be compared to signed and unsigned numbers freely. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/bca86202a48b2afa527b6e40d8b360ce3bc7c2e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkTypes.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299943002/1
5 years, 4 months ago (2015-08-18 18:06:04 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-18 18:06:04 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1976)
5 years, 4 months ago (2015-08-18 18:06:56 UTC) #5
reed1
lgtm
5 years, 4 months ago (2015-08-19 15:26:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299943002/1
5 years, 4 months ago (2015-08-19 15:26:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/bca86202a48b2afa527b6e40d8b360ce3bc7c2e7
5 years, 4 months ago (2015-08-19 15:28:19 UTC) #9
caryclark
5 years, 4 months ago (2015-08-19 17:12:44 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1285263007/ by caryclark@google.com.

The reason for reverting is: fails on chrome build on windows.

Powered by Google App Engine
This is Rietveld 408576698