Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: tools/gypv8sh.py

Issue 1299893002: Improve error handling for js2gtest C++ generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing newline. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/js2gtest.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gypv8sh.py
diff --git a/tools/gypv8sh.py b/tools/gypv8sh.py
index 2a1fada8a5729fd033a26e368ae2546f5d3a5b28..d1f246c8b4fc37f434e6914c4456153a3bf237f7 100755
--- a/tools/gypv8sh.py
+++ b/tools/gypv8sh.py
@@ -65,6 +65,9 @@ def main ():
p = subprocess.Popen(
cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, bufsize=0)
out, err = p.communicate()
+ if p.returncode != 0:
+ sys.stderr.write(out + err);
+ return 1
if not HasSameContent(cxxoutfile, out):
with open(cxxoutfile, 'wb') as f:
f.write(out)
« no previous file with comments | « chrome/test/base/js2gtest.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698