Improve error handling for js2gtest C++ generation.

Improve error handling for js2gtest C++ generation.

Previously, an error in a javascript file would cause the error to be written
to the -gen.cc file and fed to the C++ compiler (rarely accepts such
output as valid C++).  This change causes the generation build action to fail
and the error to be output to the stderr of the ninja process instead.
Also, stack traces are improved by annotating eval'd files with sourceURL
comments when running the generator.

BUG=None

Committed: https://crrev.com/2cadf1ff8e88b5471c0926ee247af5eb6eb297e6
Cr-Commit-Position: refs/heads/master@{#345964}

[Peter Lundblad, 2015-08-18 13:16:26]

The CQ bit was checked by plundblad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-18 13:16:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299893002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299893002/1

[commit-bot: I haz the power, 2015-08-18 13:57:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 13:57:44]

Dry run: This issue passed the CQ dry run.

[Peter Lundblad, 2015-08-19 07:27:09]

plundblad@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-08-19 16:53:18]

I'm not familiar with chrome/test/base/js2gtest.js. Can you find another owner?

[Peter Lundblad, 2015-08-20 08:45:12]

plundblad@chromium.org changed reviewers:
+ dtseng@chromium.org

[Peter Lundblad, 2015-08-20 08:45:12]

+David.

@sky: chromevox uses this test framework a lot, would you be fine adding
chromevox developers as owners for these files?

[sky, 2015-08-20 16:53:06]

The people that have contributed substantially to this file should be
owners. Looks like Sheridan created this file and arv reviewed it.
Both aren't around anymore.
dtseng seems to have contributed quite a few patches, so I'm fine
adding him as an owner. I'm also adding dbean and estade to this email
in case they have thoughts for good owners.

On Thu, Aug 20, 2015 at 1:45 AM,  <plundblad@chromium.org> wrote:
> +David.
>
> @sky: chromevox uses this test framework a lot, would you be fine adding
> chromevox developers as owners for these files?
>
> https://codereview.chromium.org/1299893002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2015-08-26 23:18:00]

lgtm

https://codereview.chromium.org/1299893002/diff/1/chrome/test/base/js2gtest.js
File chrome/test/base/js2gtest.js (right):

https://codereview.chromium.org/1299893002/diff/1/chrome/test/base/js2gtest.j...
chrome/test/base/js2gtest.js:409: output();
Optional: want to use the function() {/*!
  ...
  */}
trick to make multi-line output cleaner?

[Peter Lundblad, 2015-08-27 16:07:37]

dtseng@chromium.org writes:
> lgtm
> 
> 
> 
> 
>
https://codereview.chromium.org/1299893002/diff/1/chrome/test/base/js2gtest.js
> File chrome/test/base/js2gtest.js (right):
> 
>
https://codereview.chromium.org/1299893002/diff/1/chrome/test/base/js2gtest.j...
> chrome/test/base/js2gtest.js:409: output();
> Optional: want to use the function() {/*!
>    ...
>    */}
> trick to make multi-line output cleaner?

I went with the new and fancy es 2015 template strings instead.
Let me know what you think.

//Peter

> https://codereview.chromium.org/1299893002/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2015-08-27 17:06:31]

lgtm

https://codereview.chromium.org/1299893002/diff/20001/chrome/test/base/js2gte...
File chrome/test/base/js2gtest.js (right):

https://codereview.chromium.org/1299893002/diff/20001/chrome/test/base/js2gte...
chrome/test/base/js2gtest.js:202: return read(path) + '//# sourceURL=' + path;
nit: new line between the file and the sourceURL.

[Peter Lundblad, 2015-08-27 17:24:56]

@sky: I added David to OWNERS and he reviewed the code. Can you have a look now,
thanks?

[sky, 2015-08-27 17:26:57]

LGTM

[Peter Lundblad, 2015-08-27 19:09:51]

The CQ bit was checked by plundblad@chromium.org

[Peter Lundblad, 2015-08-27 19:09:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/1299893002/#ps60001
(title: "Add missing newline.")

[commit-bot: I haz the power, 2015-08-27 19:10:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299893002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299893002/60001

[commit-bot: I haz the power, 2015-08-27 19:58:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-27 19:59:55]

Patchset 4 (id:??) landed as
https://crrev.com/2cadf1ff8e88b5471c0926ee247af5eb6eb297e6
Cr-Commit-Position: refs/heads/master@{#345964}