Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1299823002: Disable new bookmark apps on Mac. (Closed)

Created:
5 years, 4 months ago by dominickn
Modified:
5 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable new bookmark apps on Mac. There is insufficient time for this feature to be enabled for M46. This CL disables it again, with the intention of enabling it for M47. BUG=517682 Committed: https://crrev.com/96cb8287949019a962b09b8c3ff15358646f0c8d Cr-Commit-Position: refs/heads/master@{#343853}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing reviewer feedback #

Messages

Total messages: 10 (3 generated)
dominickn
PTAL, thanks!
5 years, 4 months ago (2015-08-18 06:22:13 UTC) #2
benwells
https://codereview.chromium.org/1299823002/diff/1/extensions/browser/api/management/management_api.cc File extensions/browser/api/management/management_api.cc (left): https://codereview.chromium.org/1299823002/diff/1/extensions/browser/api/management/management_api.cc#oldcode88 extensions/browser/api/management/management_api.cc:88: if (!delegate->IsNewBookmarkAppsEnabled()) { Why is this code being deleted? ...
5 years, 4 months ago (2015-08-18 06:32:07 UTC) #3
dominickn
Thanks! https://codereview.chromium.org/1299823002/diff/1/extensions/browser/api/management/management_api.cc File extensions/browser/api/management/management_api.cc (left): https://codereview.chromium.org/1299823002/diff/1/extensions/browser/api/management/management_api.cc#oldcode88 extensions/browser/api/management/management_api.cc:88: if (!delegate->IsNewBookmarkAppsEnabled()) { On 2015/08/18 06:32:07, benwells wrote: ...
5 years, 4 months ago (2015-08-18 06:53:00 UTC) #5
benwells
lgtm
5 years, 4 months ago (2015-08-18 06:56:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299823002/40001
5 years, 4 months ago (2015-08-18 07:51:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 4 months ago (2015-08-18 08:00:51 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 08:01:31 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96cb8287949019a962b09b8c3ff15358646f0c8d
Cr-Commit-Position: refs/heads/master@{#343853}

Powered by Google App Engine
This is Rietveld 408576698