Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: Source/devtools/front_end/extensions/ExtensionView.js

Issue 1299763002: DevTools: rely upon shouldHideOnDetach when considering re-layout of elements and sources panels. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 * @constructor 32 * @constructor
33 * @extends {WebInspector.Widget} 33 * @extends {WebInspector.Widget}
34 * @param {!WebInspector.ExtensionServer} server 34 * @param {!WebInspector.ExtensionServer} server
35 * @param {string} id 35 * @param {string} id
36 * @param {string} src 36 * @param {string} src
37 * @param {string} className 37 * @param {string} className
38 */ 38 */
39 WebInspector.ExtensionView = function(server, id, src, className) 39 WebInspector.ExtensionView = function(server, id, src, className)
40 { 40 {
41 WebInspector.Widget.call(this); 41 WebInspector.Widget.call(this);
42 this.setHideOnDetach();
42 this.element.className = "vbox flex-auto"; // Override 43 this.element.className = "vbox flex-auto"; // Override
43 44
44 this._server = server; 45 this._server = server;
45 this._id = id; 46 this._id = id;
46 this._iframe = createElement("iframe"); 47 this._iframe = createElement("iframe");
47 this._iframe.addEventListener("load", this._onLoad.bind(this), false); 48 this._iframe.addEventListener("load", this._onLoad.bind(this), false);
48 this._iframe.src = src; 49 this._iframe.src = src;
49 this._iframe.className = className; 50 this._iframe.className = className;
50 this.setDefaultFocusedElement(this._iframe); 51 this.setDefaultFocusedElement(this._iframe);
51 52
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 this._server.notifyViewShown(this._id); 97 this._server.notifyViewShown(this._id);
97 }, 98 },
98 99
99 willHide: function() 100 willHide: function()
100 { 101 {
101 this._server.notifyViewHidden(this._id); 102 this._server.notifyViewHidden(this._id);
102 }, 103 },
103 104
104 __proto__: WebInspector.VBox.prototype 105 __proto__: WebInspector.VBox.prototype
105 } 106 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698