Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 1299763002: DevTools: rely upon shouldHideOnDetach when considering re-layout of elements and sources panels. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 * @constructor 184 * @constructor
185 * @extends {WebInspector.SidebarPane} 185 * @extends {WebInspector.SidebarPane}
186 * @param {!WebInspector.ExtensionServer} server 186 * @param {!WebInspector.ExtensionServer} server
187 * @param {string} panelName 187 * @param {string} panelName
188 * @param {string} title 188 * @param {string} title
189 * @param {string} id 189 * @param {string} id
190 */ 190 */
191 WebInspector.ExtensionSidebarPane = function(server, panelName, title, id) 191 WebInspector.ExtensionSidebarPane = function(server, panelName, title, id)
192 { 192 {
193 WebInspector.SidebarPane.call(this, title); 193 WebInspector.SidebarPane.call(this, title);
194 this.setHideOnDetach();
195 this._panelName = panelName; 194 this._panelName = panelName;
196 this._server = server; 195 this._server = server;
197 this._id = id; 196 this._id = id;
198 } 197 }
199 198
200 WebInspector.ExtensionSidebarPane.prototype = { 199 WebInspector.ExtensionSidebarPane.prototype = {
201 /** 200 /**
202 * @return {string} 201 * @return {string}
203 */ 202 */
204 id: function() 203 id: function()
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 if (!title) 308 if (!title)
310 section.titleLessMode(); 309 section.titleLessMode();
311 section.expand(); 310 section.expand();
312 section.editable = false; 311 section.editable = false;
313 this._objectPropertiesView.element.appendChild(section.element); 312 this._objectPropertiesView.element.appendChild(section.element);
314 callback(); 313 callback();
315 }, 314 },
316 315
317 __proto__: WebInspector.SidebarPane.prototype 316 __proto__: WebInspector.SidebarPane.prototype
318 } 317 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698