Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 129973002: Revert partially "cros: Use AlertDialog for remora device requisition." (Closed)

Created:
6 years, 11 months ago by mtomasz
Modified:
6 years, 11 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, matthewyuan
Visibility:
Public.

Description

Revert partially "cros: Use AlertDialog for remora device requisition." This reverts the webui change from the commit 9cc0da7de2e00c403bb2672762009148e1846078 (https://codereview.chromium.org/61523002/). The reverted webui change breaks alert dialogs in the Files app by making them not closable by pressing the Escape key. TEST=Tested manually in Files app. BUG=330835, 331739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M ui/webui/resources/js/cr/ui/dialogs.js View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtomasz
@arv: PTAL. This is a manual partial revert, which we have to merge back to ...
6 years, 11 months ago (2014-01-09 01:00:09 UTC) #1
xiyuan
LGTM
6 years, 11 months ago (2014-01-09 03:05:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/129973002/1
6 years, 11 months ago (2014-01-09 09:47:38 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244015
6 years, 11 months ago (2014-01-09 12:41:53 UTC) #4
arv (Not doing code reviews)
What is "remora device requisition"?
6 years, 11 months ago (2014-01-09 15:28:08 UTC) #5
arv (Not doing code reviews)
LGTM
6 years, 11 months ago (2014-01-09 15:28:31 UTC) #6
mtomasz
On 2014/01/09 15:28:31, arv wrote: > LGTM @arv: I have no idea. @xiyuan should know.
6 years, 11 months ago (2014-01-09 22:42:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/129973002/1
6 years, 11 months ago (2014-01-09 22:48:23 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 03:06:59 UTC) #9
Message was sent while issue was closed.
Change committed as 244064

Powered by Google App Engine
This is Rietveld 408576698