Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: Source/platform/mac/VersionUtilMacTest.mm

Issue 1299713004: Reland #2: Add a short term solution to fix OSX 10.11 system font rendering problems. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase against top of tree. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/mac/VersionUtilMac.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "config.h" 5 #import "config.h"
6 #import "platform/mac/VersionUtilMac.h" 6 #import "platform/mac/VersionUtilMac.h"
7 7
8 #include <AppKit/AppKit.h> 8 #include <AppKit/AppKit.h>
9 #include <gtest/gtest.h> 9 #include <gtest/gtest.h>
10 10
11 #ifndef NSAppKitVersionNumber10_7 11 #ifndef NSAppKitVersionNumber10_7
12 #define NSAppKitVersionNumber10_7 1138 12 #define NSAppKitVersionNumber10_7 1138
13 #endif 13 #endif
14 14
15 #ifndef NSAppKitVersionNumber10_9 15 #ifndef NSAppKitVersionNumber10_9
16 #define NSAppKitVersionNumber10_9 1265 16 #define NSAppKitVersionNumber10_9 1265
17 #endif 17 #endif
18 18
19 #ifndef NSAppKitVersionNumber10_10 19 #ifndef NSAppKitVersionNumber10_10
20 #define NSAppKitVersionNumber10_10 1343 20 #define NSAppKitVersionNumber10_10 1343
21 #endif 21 #endif
22 22
23 // This number was determined by writing a tiny Cocoa App on 10.10.4. 23 // This number was determined by writing a tiny Cocoa App on 10.10.4.
24 #define NSAppKitVersionNumber10_10Max 1348 24 #define NSAppKitVersionNumber10_10Max 1348
25 25
26 // This number was measured on OSX 10.11 Beta 15A234d. The 10.11
27 // AppKit.framework does not provide an NSAppKitVersionNumber preprocessor
28 // definition for OSX 10.11.
29 #define NSAppKitVersionNumber10_11Max 1389
30
26 // AppKit version is loosely correlated to OSX version. It's still useful as a 31 // AppKit version is loosely correlated to OSX version. It's still useful as a
27 // sanity check in unit tests, though we don't want to rely on it in production 32 // sanity check in unit tests, though we don't want to rely on it in production
28 // code. 33 // code.
29 TEST(VersionUtilMac, AppKitVersions) 34 TEST(VersionUtilMac, AppKitVersions)
30 { 35 {
31 if (floor(NSAppKitVersionNumber) <= NSAppKitVersionNumber10_7) { 36 if (floor(NSAppKitVersionNumber) <= NSAppKitVersionNumber10_7) {
32 EXPECT_TRUE(blink::IsOSLionOrEarlier()); 37 EXPECT_TRUE(blink::IsOSLionOrEarlier());
33 EXPECT_TRUE(blink::IsOSMavericksOrEarlier()); 38 EXPECT_TRUE(blink::IsOSMavericksOrEarlier());
34 EXPECT_FALSE(blink::IsOSMavericks()); 39 EXPECT_FALSE(blink::IsOSMavericks());
40 EXPECT_FALSE(blink::IsOSYosemite());
41 EXPECT_FALSE(blink::IsOSElCapitan());
35 return; 42 return;
36 } 43 }
37 44
38 if (floor(NSAppKitVersionNumber) < NSAppKitVersionNumber10_9) { 45 if (floor(NSAppKitVersionNumber) < NSAppKitVersionNumber10_9) {
39 EXPECT_FALSE(blink::IsOSLionOrEarlier()); 46 EXPECT_FALSE(blink::IsOSLionOrEarlier());
40 EXPECT_TRUE(blink::IsOSMavericksOrEarlier()); 47 EXPECT_TRUE(blink::IsOSMavericksOrEarlier());
41 EXPECT_FALSE(blink::IsOSMavericks()); 48 EXPECT_FALSE(blink::IsOSMavericks());
49 EXPECT_FALSE(blink::IsOSYosemite());
50 EXPECT_FALSE(blink::IsOSElCapitan());
42 return; 51 return;
43 } 52 }
53
44 if (floor(NSAppKitVersionNumber) == NSAppKitVersionNumber10_9) { 54 if (floor(NSAppKitVersionNumber) == NSAppKitVersionNumber10_9) {
45 EXPECT_FALSE(blink::IsOSLionOrEarlier()); 55 EXPECT_FALSE(blink::IsOSLionOrEarlier());
46 EXPECT_TRUE(blink::IsOSMavericksOrEarlier()); 56 EXPECT_TRUE(blink::IsOSMavericksOrEarlier());
47 EXPECT_TRUE(blink::IsOSMavericks()); 57 EXPECT_TRUE(blink::IsOSMavericks());
58 EXPECT_FALSE(blink::IsOSYosemite());
59 EXPECT_FALSE(blink::IsOSElCapitan());
48 return; 60 return;
49 } 61 }
62
50 if (floor(NSAppKitVersionNumber) <= NSAppKitVersionNumber10_10Max && 63 if (floor(NSAppKitVersionNumber) <= NSAppKitVersionNumber10_10Max &&
51 floor(NSAppKitVersionNumber) >= NSAppKitVersionNumber10_10) { 64 floor(NSAppKitVersionNumber) >= NSAppKitVersionNumber10_10) {
52 EXPECT_FALSE(blink::IsOSLionOrEarlier()); 65 EXPECT_FALSE(blink::IsOSLionOrEarlier());
53 EXPECT_FALSE(blink::IsOSMavericksOrEarlier()); 66 EXPECT_FALSE(blink::IsOSMavericksOrEarlier());
54 EXPECT_FALSE(blink::IsOSMavericks()); 67 EXPECT_FALSE(blink::IsOSMavericks());
68 EXPECT_TRUE(blink::IsOSYosemite());
69 EXPECT_FALSE(blink::IsOSElCapitan());
70 return;
71 }
72
73 if (floor(NSAppKitVersionNumber) == NSAppKitVersionNumber10_11Max) {
74 EXPECT_FALSE(blink::IsOSLionOrEarlier());
75 EXPECT_FALSE(blink::IsOSMavericksOrEarlier());
76 EXPECT_FALSE(blink::IsOSMavericks());
77 EXPECT_FALSE(blink::IsOSYosemite());
78 EXPECT_TRUE(blink::IsOSElCapitan());
55 return; 79 return;
56 } 80 }
57 } 81 }
OLDNEW
« no previous file with comments | « Source/platform/mac/VersionUtilMac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698