Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1299713004: Reland #2: Add a short term solution to fix OSX 10.11 system font rendering problems. (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
Reviewers:
keishi, tkent, Nico
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland #2: Add a short term solution to fix OSX 10.11 system font rendering problems. The mechanism that Blink was using to determine OSX version number was not reliable. This has since been fixed. > I landed a CL (https://codereview.chromium.org/1276003003/) which fixes system > font problems on OSX 10.9 and OSX 10.10. The CL also fixed MatchNSFontFamily() > to correctly return the system font on 10.11, but this causes glyph rendering > problems. In the short term, I'm adding logic to MatchNSFontFamily() to return > nil on 10.11, which was the original behavior before I landed that CL. > > BUG=521034 > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200618 BUG=521034 TBR=tkent@chromium.org, keishi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200855

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Rebase against top of tree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M Source/platform/fonts/mac/FontFamilyMatcherMac.mm View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/platform/fonts/mac/FontFamilyMatcherMacTest.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mac/VersionUtilMac.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/platform/mac/VersionUtilMac.mm View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M Source/platform/mac/VersionUtilMacTest.mm View 1 2 3 4 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
erikchen
thakis: Please review. Note that there is no change to the functionality since the original ...
5 years, 4 months ago (2015-08-17 23:51:01 UTC) #2
erikchen
On 2015/08/17 23:51:01, erikchen wrote: > thakis: Please review. > > Note that there is ...
5 years, 4 months ago (2015-08-17 23:51:10 UTC) #3
Nico
rs-lgtm
5 years, 4 months ago (2015-08-18 00:10:33 UTC) #4
keishi
LGTM
5 years, 4 months ago (2015-08-18 03:30:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299713004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299713004/80001
5 years, 4 months ago (2015-08-19 21:50:07 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 22:36:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200855

Powered by Google App Engine
This is Rietveld 408576698