GLImage::OnMemoryDump Stubs + Some Impls

ui/gl/gl_image_shared_memory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_image_shared_memory.h"
 
 #include "base/logging.h"
 #include "base/numerics/safe_math.h"
 #include "base/process/process_handle.h"
 
@@ skipping 15 matching lines @@
   if (!s.IsValid())
     return false;
   *size_in_bytes = s.ValueOrDie();
   return true;
 }
 
 }  // namespace
 
 GLImageSharedMemory::GLImageSharedMemory(const gfx::Size& size,
                                          unsigned internalformat)
-    : GLImageMemory(size, internalformat) {
-}
+    : GLImageMemory(size, internalformat) {}
 
 GLImageSharedMemory::~GLImageSharedMemory() {
   DCHECK(!shared_memory_);
 }
 
 bool GLImageSharedMemory::Initialize(const gfx::GpuMemoryBufferHandle& handle,
                                      gfx::BufferFormat format) {
   size_t size_in_bytes;
   if (!SizeInBytes(GetSize(), format, &size_in_bytes))
     return false;
@@ skipping 18 matching lines @@
     return false;
   }
 
   if (!GLImageMemory::Initialize(
           static_cast<unsigned char*>(duped_shared_memory->memory()), format)) {
     return false;
   }
 
   DCHECK(!shared_memory_);
   shared_memory_ = duped_shared_memory.Pass();
+  shared_memory_id_ = handle.id;
   return true;
 }
 
 void GLImageSharedMemory::Destroy(bool have_context) {
   GLImageMemory::Destroy(have_context);
   shared_memory_.reset();
 }
 
+void GLImageSharedMemory::OnMemoryDump(
+    base::trace_event::ProcessMemoryDump* pmd,
+    uint64_t process_tracing_id,
+    const std::string& dump_name) {

[reveman, 2015/08/18 08:32:52]

This function should report 0 size or early out after ::Destroy has been called.
Early out to be consistent with GLImageRefCountedMemory.

[ericrk, 2015/08/18 09:00:47]

Switched both to report 0.

+  size_t size_bytes;
+  SizeInBytes(GetSize(), format(), &size_bytes);
+
+  base::trace_event::MemoryAllocatorDump* dump =
+      pmd->CreateAllocatorDump(dump_name);
+  dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
+                  base::trace_event::MemoryAllocatorDump::kUnitsBytes,
+                  static_cast<uint64_t>(size_bytes));
+
+  auto guid = gfx::GetGenericSharedMemoryGUIDForTracing(process_tracing_id,
+                                                        shared_memory_id_);
+  pmd->CreateSharedGlobalAllocatorDump(guid);
+  pmd->AddOwnershipEdge(dump->guid(), guid);
+}
+
 }  // namespace gfx