GLImage::OnMemoryDump Stubs + Some Impls

ui/gl/gl_image.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GL_GL_IMAGE_H_
 #define UI_GL_GL_IMAGE_H_
 
 #include "base/memory/ref_counted.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/rect_f.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gfx/overlay_transform.h"
 #include "ui/gl/gl_export.h"
 
+namespace base {
+namespace trace_event {
+class ProcessMemoryDump;
+}  // trace_event
+}  // base

[reveman, 2015/08/18 08:32:52]

nit: not sure the closing "}" comments are needed

[ericrk, 2015/08/18 09:00:47]

Done.

+
 namespace gfx {
 
 // Encapsulates an image that can be bound to a texture, hiding platform
 // specific management.
 class GL_EXPORT GLImage : public base::RefCounted<GLImage> {
  public:
   GLImage() {}
 
   // Destroys the image.
   virtual void Destroy(bool have_context) = 0;
@@ skipping 27 matching lines @@
   // Called after the texture image data has been modified.
   virtual void DidModifyTexImage() = 0;
 
   // Schedule image as an overlay plane to be shown at swap time for |widget|.
   virtual bool ScheduleOverlayPlane(gfx::AcceleratedWidget widget,
                                     int z_order,
                                     OverlayTransform transform,
                                     const Rect& bounds_rect,
                                     const RectF& crop_rect) = 0;
 
+  virtual void OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd,

[reveman, 2015/08/18 08:32:52]

All other functions have a short comment that describes them. Can you add one
here? 

[ericrk, 2015/08/18 09:00:47]

Done.

+                            uint64_t process_tracing_id,
+                            const std::string& dump_name) = 0;
+
  protected:
   virtual ~GLImage() {}
 
  private:
   friend class base::RefCounted<GLImage>;
 
   DISALLOW_COPY_AND_ASSIGN(GLImage);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GL_GL_IMAGE_H_