Handle missing EMMA files.

Handle missing EMMA files.

When EMMA files are missing (i.e. the emma_filter didn't cover the java
source file that was changed) the script should still run properly.
Handled missing EMMA files by skipping them and only running coverage
stats on source files that have corresponding EMMA files.

Also updated tests.

BUG=

Committed: https://crrev.com/7d5973f6998a87987c474585fe1ac3179a39480b
Cr-Commit-Position: refs/heads/master@{#343917}

[estevenson1, 2015-08-17 18:35:43]

estevenson@google.com changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org

[mikecase (-- gone --), 2015-08-17 18:53:57]

https://codereview.chromium.org/1299693003/diff/1/build/android/emma_coverage...
File build/android/emma_coverage_stats.py (right):

https://codereview.chromium.org/1299693003/diff/1/build/android/emma_coverage...
build/android/emma_coverage_stats.py:292: emma_file =
self._source_to_emma[file_path]
nit: This will get a key error if file_path is not in self._source_to_emma which
could create some confusion in the future.

I would either...
(1) Add to the documentation for Args:file_path that this file must have
coverage info generated for it.

Or...
(2) Just return None is file_path is not in self._source_to_emma in this
function. If you do this you might want to change your logic where you call this
to something like....

for file_path, line_numbers in lines_for_coverage.iteritems():
  coverage_dict = self.GetcoverageDictForFile(file_path, line_number)
  if coverage_dict:
    file_coverage[file_path] = coverage_dict

[estevenson1, 2015-08-17 19:06:17]

https://codereview.chromium.org/1299693003/diff/1/build/android/emma_coverage...
File build/android/emma_coverage_stats.py (right):

https://codereview.chromium.org/1299693003/diff/1/build/android/emma_coverage...
build/android/emma_coverage_stats.py:292: emma_file =
self._source_to_emma[file_path]
On 2015/08/17 at 18:53:57, mikecase wrote:
> nit: This will get a key error if file_path is not in self._source_to_emma
which could create some confusion in the future.
> 
> I would either...
> (1) Add to the documentation for Args:file_path that this file must have
coverage info generated for it.
> 
> Or...
> (2) Just return None is file_path is not in self._source_to_emma in this
function. If you do this you might want to change your logic where you call this
to something like....
> 
> for file_path, line_numbers in lines_for_coverage.iteritems():
>   coverage_dict = self.GetcoverageDictForFile(file_path, line_number)
>   if coverage_dict:
>     file_coverage[file_path] = coverage_dict

Done. Added a test for it as well.

[mikecase (-- gone --), 2015-08-17 19:22:27]

lgtm

[jbudorick, 2015-08-17 19:25:57]

lgtm w/ minor nit

https://codereview.chromium.org/1299693003/diff/20001/build/android/emma_cove...
File build/android/emma_coverage_stats.py (right):

https://codereview.chromium.org/1299693003/diff/20001/build/android/emma_cove...
build/android/emma_coverage_stats.py:382: if  package in package_to_emma}
nit: one space after if

[estevenson1, 2015-08-17 19:30:41]

https://codereview.chromium.org/1299693003/diff/20001/build/android/emma_cove...
File build/android/emma_coverage_stats.py (right):

https://codereview.chromium.org/1299693003/diff/20001/build/android/emma_cove...
build/android/emma_coverage_stats.py:382: if  package in package_to_emma}
On 2015/08/17 at 19:25:57, jbudorick wrote:
> nit: one space after if

Done.

[estevenson1, 2015-08-17 19:31:14]

The CQ bit was checked by estevenson@google.com

[estevenson1, 2015-08-17 19:31:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1299693003/#ps40001
(title: "Addressed jbudorick comment.")

[commit-bot: I haz the power, 2015-08-17 19:33:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299693003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299693003/40001

[commit-bot: I haz the power, 2015-08-17 22:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-17 22:07:02]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estevenson1, 2015-08-17 22:29:42]

The CQ bit was checked by estevenson@google.com

[commit-bot: I haz the power, 2015-08-17 22:31:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299693003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299693003/40001

[commit-bot: I haz the power, 2015-08-18 01:06:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 01:06:08]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estevenson1, 2015-08-18 14:16:05]

The CQ bit was checked by estevenson@google.com

[commit-bot: I haz the power, 2015-08-18 14:16:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299693003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299693003/40001

[commit-bot: I haz the power, 2015-08-18 14:49:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-18 14:50:49]

Patchset 3 (id:??) landed as
https://crrev.com/7d5973f6998a87987c474585fe1ac3179a39480b
Cr-Commit-Position: refs/heads/master@{#343917}