gpu: If not cube complete, the texture isn't renderable, no matter mipmap complete.

gpu/command_buffer/service/texture_manager.cc

Index: gpu/command_buffer/service/texture_manager.cc
diff --git a/gpu/command_buffer/service/texture_manager.cc b/gpu/command_buffer/service/texture_manager.cc
index ed0fd10e5b1e6e1ae96fc5b0316d0be8b10290fb..5085efa040910015afd13133ab9165cf69241e7b 100644
--- a/gpu/command_buffer/service/texture_manager.cc
+++ b/gpu/command_buffer/service/texture_manager.cc
@@ -443,10 +443,11 @@ Texture::CanRenderCondition Texture::GetCanRenderCondition() const {
   if (needs_mips) {
     if (!texture_complete())
       return CAN_RENDER_NEVER;
-    if (target_ == GL_TEXTURE_CUBE_MAP && !cube_complete())
-      return CAN_RENDER_NEVER;
   }
 
+  if (target_ == GL_TEXTURE_CUBE_MAP && !cube_complete())
+    return CAN_RENDER_NEVER;

[dshwang, 2015/08/18 07:18:16]

I change the CL's goal. Texture::GetCanRenderCondition() is wrong about cube
complete. This fixes it.

Without this change, the unittest TextureTest.POTCubeMapWithoutMipmap fails as
follows;

[ RUN      ] TextureTest.POTCubeMapWithoutMipmap
../../gpu/command_buffer/service/texture_manager_unittest.cc:864: Failure
Value of: manager_->CanRender(texture_ref_.get())
  Actual: true
Expected: false
../../gpu/command_buffer/service/texture_manager_unittest.cc:865: Failure
Value of: manager_->HaveUnrenderableTextures()
  Actual: false
Expected: true
../../gpu/command_buffer/service/texture_manager_unittest.cc:873: Failure
Value of: manager_->CanRender(texture_ref_.get())
  Actual: true
Expected: false
../../gpu/command_buffer/service/texture_manager_unittest.cc:874: Failure
Value of: manager_->HaveUnrenderableTextures()
  Actual: false
Expected: true
../../gpu/command_buffer/service/texture_manager_unittest.cc:882: Failure
Value of: manager_->CanRender(texture_ref_.get())
  Actual: true
Expected: false
../../gpu/command_buffer/service/texture_manager_unittest.cc:883: Failure
Value of: manager_->HaveUnrenderableTextures()
  Actual: false
Expected: true
../../gpu/command_buffer/service/texture_manager_unittest.cc:890: Failure
Value of: manager_->CanRender(texture_ref_.get())
  Actual: true
Expected: false
../../gpu/command_buffer/service/texture_manager_unittest.cc:892: Failure
Value of: manager_->HaveUnrenderableTextures()
  Actual: false
Expected: true
../../gpu/command_buffer/service/texture_manager_unittest.cc:900: Failure
Value of: manager_->CanRender(texture_ref_.get())
  Actual: true
Expected: false
../../gpu/command_buffer/service/texture_manager_unittest.cc:901: Failure
Value of: manager_->HaveUnrenderableTextures()
  Actual: false
Expected: true
[  FAILED  ] TextureTest.POTCubeMapWithoutMipmap (1 ms)

+
   bool is_npot_compatible = !needs_mips &&
       wrap_s_ == GL_CLAMP_TO_EDGE &&
       wrap_t_ == GL_CLAMP_TO_EDGE;