Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1299653004: Revert "Reland 2: mac: Use a placeholder string for the family name of the system font." (branch 248 (Closed)

Created:
5 years, 4 months ago by erikchen
Modified:
5 years, 4 months ago
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, drott+blinkwatch_chromium.org, Rik, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, Justin Novosad, jbroman, danakj, blink-reviews-rendering, f(malita), jchaffraix+rendering, dshwang, Stephen Chennney, pdr+graphicswatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@2485
Target Ref:
refs/branch-heads/chromium/2485
Project:
blink
Visibility:
Public.

Description

Revert "Reland 2: mac: Use a placeholder string for the family name of the system font." Branch 2485 This reverts commit c05256796e62264bd6f477581b905a02105b0aa1. BUG=521034 TBR=tkent@chromium.org, keishi@chromium.org, thakis@chromium.org NOTRY=true NOPRESUBMIT=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200665 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -217 lines) Patch
M Source/core/layout/LayoutTextControlMultiLine.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutTextControlSingleLine.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/layout/LayoutTheme.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutThemeMac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutThemeMac.mm View 3 chunks +2 lines, -10 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/platform/blink_platform.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/platform/fonts/mac/FontCacheMac.mm View 3 chunks +19 lines, -3 lines 0 comments Download
M Source/platform/fonts/mac/FontFamilyMatcherMac.h View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/platform/fonts/mac/FontFamilyMatcherMac.mm View 7 chunks +5 lines, -84 lines 0 comments Download
D Source/platform/fonts/mac/FontFamilyMatcherMacTest.mm View 1 chunk +0 lines, -41 lines 0 comments Download
M Source/platform/mac/ThemeMac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/mac/ThemeMac.mm View 2 chunks +13 lines, -1 line 0 comments Download
D Source/platform/mac/VersionUtilMac.h View 1 chunk +0 lines, -18 lines 0 comments Download
D Source/platform/mac/VersionUtilMac.mm View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299653004/1
5 years, 4 months ago (2015-08-17 20:37:04 UTC) #2
erikchen
On 2015/08/17 20:37:04, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 4 months ago (2015-08-17 20:44:59 UTC) #4
erikchen
On 2015/08/17 20:44:59, erikchen wrote: > On 2015/08/17 20:37:04, commit-bot: I haz the power wrote: ...
5 years, 4 months ago (2015-08-17 20:46:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299653004/1
5 years, 4 months ago (2015-08-17 20:55:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200665
5 years, 4 months ago (2015-08-17 20:56:32 UTC) #8
erikchen
5 years, 4 months ago (2015-08-17 20:59:54 UTC) #9
erikchen
5 years, 4 months ago (2015-08-17 21:00:08 UTC) #11
Ken Russell (switch to Gerrit)
Committed patchset #1 (id:1) manually as 200668 (presubmit successful).
5 years, 4 months ago (2015-08-17 21:14:12 UTC) #12
leviw_travelin_and_unemployed
On 2015/08/17 at 21:14:12, kbr wrote: > Committed patchset #1 (id:1) manually as 200668 (presubmit ...
5 years, 4 months ago (2015-08-17 22:14:38 UTC) #13
erikchen
On 2015/08/17 22:14:38, leviw wrote: > On 2015/08/17 at 21:14:12, kbr wrote: > > Committed ...
5 years, 4 months ago (2015-08-17 22:22:30 UTC) #14
leviw_travelin_and_unemployed
5 years, 4 months ago (2015-08-17 22:37:08 UTC) #15
Message was sent while issue was closed. 
On 2015/08/17 at 22:22:30, erikchen wrote:
> On 2015/08/17 22:14:38, leviw wrote:
> > On 2015/08/17 at 21:14:12, kbr wrote:
> > > Committed patchset #1 (id:1) manually as 200668 (presubmit successful).
> > 
> > This seems to have caused a number of bots to begin failing
> > fast/forms/text-control-intrinsic-widths.html
> > 
> > Is this expected? Does it just need to be rebaselined?
> > 
> >
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas...
> 
> This was never intended to be reverted on trunk. I tried to CQ this patch onto
branch 2485, but the CQ sent it to trunk instead. The unexpected trunk revert
was reverted at https://codereview.chromium.org/1292593003/

Ty for the info. I was a bit confused by the description :)

Powered by Google App Engine
This is Rietveld 408576698