Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: content/browser/devtools/protocol/input_handler.cc

Issue 1299643004: Make synthesizeScrollGesture repetable and emit interaction markers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a TODO Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/protocol/input_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/input_handler.cc
diff --git a/content/browser/devtools/protocol/input_handler.cc b/content/browser/devtools/protocol/input_handler.cc
index fb24b021b3c44b0ca26a3568fbf91c8304c9edbb..d5b2d8b8fced913c196ed4461ee63c6a5c7c73a2 100644
--- a/content/browser/devtools/protocol/input_handler.cc
+++ b/content/browser/devtools/protocol/input_handler.cc
@@ -4,8 +4,10 @@
#include "content/browser/devtools/protocol/input_handler.h"
+#include "base/message_loop/message_loop.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/trace_event/trace_event.h"
#include "cc/output/compositor_frame_metadata.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/common/input/synthetic_pinch_gesture_params.h"
@@ -346,6 +348,25 @@ Response InputHandler::SynthesizeScrollGesture(
const bool* prevent_fling,
const int* speed,
const std::string* gesture_source_type) {
+ return SynthesizeScrollGesture(
+ command_id, x, y, x_distance, y_distance, x_overscroll, y_overscroll,
+ prevent_fling, speed, gesture_source_type, nullptr, nullptr, nullptr);
+}
+
+Response InputHandler::SynthesizeScrollGesture(
+ DevToolsCommandId command_id,
+ int x,
+ int y,
+ const int* x_distance,
+ const int* y_distance,
+ const int* x_overscroll,
+ const int* y_overscroll,
+ const bool* prevent_fling,
+ const int* speed,
+ const std::string* gesture_source_type,
+ const int* repeat_count,
+ const int* repeat_delay_ms,
+ const std::string* interaction_marker_name) {
if (!host_)
return Response::ServerError("Could not connect to view");
@@ -378,12 +399,60 @@ Response InputHandler::SynthesizeScrollGesture(
return Response::InvalidParams("gestureSourceType");
}
+ SynthesizeRepeatingScroll(
+ gesture_params, repeat_count ? *repeat_count : 0,
+ base::TimeDelta::FromMilliseconds(repeat_delay_ms ? *repeat_delay_ms
+ : 250),
+ interaction_marker_name ? *interaction_marker_name : "", command_id);
+
+ return Response::OK();
+}
+
+void InputHandler::SynthesizeRepeatingScroll(
+ SyntheticSmoothScrollGestureParams gesture_params,
+ int repeat_count,
+ base::TimeDelta repeat_delay,
+ std::string interaction_marker_name,
+ DevToolsCommandId command_id) {
+ if (!interaction_marker_name.empty()) {
+ // Telemetry expects the interaction markers to be in the blink.console
+ // category.
+ // TODO(alexclarke): Can we move this elsewhere? It doesn't really fit here.
+ TRACE_EVENT_COPY_ASYNC_BEGIN0("blink.console",
+ interaction_marker_name.c_str(), command_id);
+ }
+
host_->QueueSyntheticGesture(
SyntheticGesture::Create(gesture_params),
- base::Bind(&InputHandler::SendSynthesizeScrollGestureResponse,
- weak_factory_.GetWeakPtr(), command_id));
+ base::Bind(&InputHandler::OnScrollFinished, weak_factory_.GetWeakPtr(),
+ gesture_params, repeat_count, repeat_delay,
+ interaction_marker_name, command_id));
+}
- return Response::OK();
+void InputHandler::OnScrollFinished(
+ SyntheticSmoothScrollGestureParams gesture_params,
+ int repeat_count,
+ base::TimeDelta repeat_delay,
+ std::string interaction_marker_name,
+ DevToolsCommandId command_id,
+ SyntheticGesture::Result result) {
+ if (!interaction_marker_name.empty()) {
+ // Telemetry expects the interaction markers to be in the blink.console
+ // category.
+ TRACE_EVENT_COPY_ASYNC_END0("blink.console",
+ interaction_marker_name.c_str(), command_id);
+ }
+
+ if (repeat_count > 0) {
+ base::MessageLoop::current()->task_runner()->PostDelayedTask(
+ FROM_HERE,
+ base::Bind(&InputHandler::SynthesizeRepeatingScroll,
+ weak_factory_.GetWeakPtr(), gesture_params, repeat_count - 1,
+ repeat_delay, interaction_marker_name, command_id),
+ repeat_delay);
+ } else {
+ SendSynthesizeScrollGestureResponse(command_id, result);
+ }
}
Response InputHandler::SynthesizeTapGesture(
« no previous file with comments | « content/browser/devtools/protocol/input_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698