Only evacuation candidate pages have a slots buffer, just visit these pages when filtering slots.

Only evacuation candidate pages have a slots buffer, just visit these pages when filtering slots.

BUG=

Committed: https://crrev.com/51333720cd73213b9fd7264428ea3922699b979a
Cr-Commit-Position: refs/heads/master@{#30211}

[Hannes Payer (out of office), 2015-08-18 05:40:29]

hpayer@chromium.org changed reviewers:
+ mlippautz@chromium.org

[Michael Lippautz, 2015-08-18 07:05:01]

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#ol...
src/heap/mark-compact.cc:287: void
MarkCompactCollector::ClearInvalidSlotsBufferEntries(PagedSpace* space) {
Should be dead code now?

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:299: int npages = evacuation_candidates_.length();
nit: num_pages

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:302: SlotsBuffer::RemoveInvalidSlots(heap_,
p->slots_buffer());
Just a comment: Ideally we want to remove the static methods and end up at 
  page->RemoveInvalidSlots();
?

[Hannes Payer (out of office), 2015-08-18 08:00:09]

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#ol...
src/heap/mark-compact.cc:287: void
MarkCompactCollector::ClearInvalidSlotsBufferEntries(PagedSpace* space) {
On 2015/08/18 07:05:01, Michael Lippautz wrote:
> Should be dead code now?

Done.

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:299: int npages = evacuation_candidates_.length();
On 2015/08/18 07:05:01, Michael Lippautz wrote:
> nit: num_pages

Done.

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:302: SlotsBuffer::RemoveInvalidSlots(heap_,
p->slots_buffer());
On 2015/08/18 07:05:01, Michael Lippautz wrote:
> Just a comment: Ideally we want to remove the static methods and end up at 
>   page->RemoveInvalidSlots();
> ?

Page cannot now about the filtering rules, that would be the wrong abstraction.
An option would be to make it part of MarkCompactCollector.

[Michael Lippautz, 2015-08-18 08:18:49]

lgtm

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1299623003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:302: SlotsBuffer::RemoveInvalidSlots(heap_,
p->slots_buffer());
On 2015/08/18 08:00:09, Hannes Payer wrote:
> On 2015/08/18 07:05:01, Michael Lippautz wrote:
> > Just a comment: Ideally we want to remove the static methods and end up at 
> >   page->RemoveInvalidSlots();
> > ?
> 
> Page cannot now about the filtering rules, that would be the wrong
abstraction.
> An option would be to make it part of MarkCompactCollector.

Acknowledged.

[Hannes Payer (out of office), 2015-08-18 08:24:27]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2015-08-18 08:24:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299623003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299623003/20001

[commit-bot: I haz the power, 2015-08-18 09:02:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-18 09:02:51]

Patchset 2 (id:??) landed as
https://crrev.com/51333720cd73213b9fd7264428ea3922699b979a
Cr-Commit-Position: refs/heads/master@{#30211}