chrome/common/extensions/docs/server2/template_data_source.py - Issue 12996003: Dynamically generate a heading for Extension Docs API pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/template_data_source.py

Issue 12996003: Dynamically generate a heading for Extension Docs API pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments - Patch currently being broken up Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/subversion_file_system.py ('k') | chrome/common/extensions/docs/server2/template_data_source_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/template_data_source.py

diff --git a/chrome/common/extensions/docs/server2/template_data_source.py b/chrome/common/extensions/docs/server2/template_data_source.py

index 63c29d72d5912cb4dcb935417578927062ea2b98..7a1f6e10258fa5e4fae9676615840911d0078006 100644

--- a/chrome/common/extensions/docs/server2/template_data_source.py

+++ b/chrome/common/extensions/docs/server2/template_data_source.py

@@ -119,7 +119,7 @@ class TemplateDataSource(object):

from the TemplateDataSource with the |get| method.

"""

template = self.GetTemplate(self._public_template_path, template_name)

- if not template:

+ if template is None:

return None

# TODO error handling

render_data = template.render({