chrome/common/extensions/docs/server2/instance_servlet.py - Issue 12996003: Dynamically generate a heading for Extension Docs API pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/instance_servlet.py

Issue 12996003: Dynamically generate a heading for Extension Docs API pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments - Patch currently being broken up Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/fake_fetchers.py ('k') | chrome/common/extensions/docs/server2/instance_servlet_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/instance_servlet.py

diff --git a/chrome/common/extensions/docs/server2/instance_servlet.py b/chrome/common/extensions/docs/server2/instance_servlet.py

index 9710de6fd3d3451b2fb9afa5a3a97ee8525c46ff..b7889819e22156ec9fd2156c6258f01a1419692a 100644

--- a/chrome/common/extensions/docs/server2/instance_servlet.py

+++ b/chrome/common/extensions/docs/server2/instance_servlet.py

@@ -37,13 +37,18 @@ class _OfflineRenderServletDelegate(RenderServlet.Delegate):

@memoize

def CreateServerInstanceForChannel(self, channel):

object_store_creator = ObjectStoreCreator(channel, start_empty=False)

- branch = (self._delegate.CreateBranchUtility(object_store_creator)

- .GetBranchForChannel(channel))

+ branch_utility = self._delegate.CreateBranchUtility(object_store_creator)

+ branch = branch_utility.GetChannelInfo(channel).branch

host_file_system = CachingFileSystem(

OfflineFileSystem(self._delegate.CreateHostFileSystemForBranch(branch)),

object_store_creator)

app_samples_file_system = self._delegate.CreateAppSamplesFileSystem(

object_store_creator)

+ def create_file_system(version):

+ return CachingFileSystem(

+ OfflineFileSystem(self._delegate.CreateHostFileSystemForBranch(

+ branch_utility.GetBranchForVersion(version))),

+ object_store_creator)

compiled_host_fs_factory = CompiledFileSystem.Factory(

host_file_system,

object_store_creator)

@@ -52,7 +57,9 @@ class _OfflineRenderServletDelegate(RenderServlet.Delegate):

host_file_system,

app_samples_file_system,

'' if channel == 'stable' else '/%s' % channel,

- compiled_host_fs_factory)

+ compiled_host_fs_factory,

+ branch_utility,

+ create_file_system)

class InstanceServlet(object):

'''Servlet for running on normal AppEngine instances.