chrome/common/extensions/docs/server2/instance_servlet.py - Issue 12996003: Dynamically generate a heading for Extension Docs API pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/instance_servlet.py

Issue 12996003: Dynamically generate a heading for Extension Docs API pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing up Offline/Online Access - Attempting to rework availability algorithm Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/cron_servlet_test.py ('K') | « chrome/common/extensions/docs/server2/fake_fetchers.py ('k') | chrome/common/extensions/docs/server2/integration_test.py » ('j') | chrome/common/extensions/docs/server2/preview.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/instance_servlet.py

diff --git a/chrome/common/extensions/docs/server2/instance_servlet.py b/chrome/common/extensions/docs/server2/instance_servlet.py

index 2523d996d47b9520784f1abd5186def52db6d4a3..2918090a9acd6adb7bff1ebe9ab5a8b148c0999a 100644

--- a/chrome/common/extensions/docs/server2/instance_servlet.py

+++ b/chrome/common/extensions/docs/server2/instance_servlet.py

@@ -38,12 +38,16 @@ class _OfflineRenderServletDelegate(RenderServlet.Delegate):

def CreateServerInstanceForChannel(self, channel):

object_store_creator = ObjectStoreCreator(channel, start_empty=False)

branch = (self._delegate.CreateBranchUtility(object_store_creator)

- .GetBranchForChannel(channel))

+ .GetChannelInfo(channel).branch)

host_file_system = CachingFileSystem(

OfflineFileSystem(self._delegate.CreateHostFileSystemForBranch(branch)),

object_store_creator)

app_samples_file_system = self._delegate.CreateAppSamplesFileSystem(

object_store_creator)

+ def create_file_system(branch):

+ return CachingFileSystem(

+ OfflineFileSystem(SubversionFileSystem.Create(branch)),

+ object_store_creator)

compiled_host_fs_factory = CompiledFileSystem.Factory(

host_file_system,

object_store_creator)

@@ -53,7 +57,8 @@ class _OfflineRenderServletDelegate(RenderServlet.Delegate):

app_samples_file_system,

'/static' if channel == 'stable' else

'/%s/static' % channel,

- compiled_host_fs_factory)

+ compiled_host_fs_factory,

+ create_file_system)

class InstanceServlet(object):

'''Servlet for running on normal AppEngine instances.