chrome/common/extensions/docs/server2/local_renderer.py - Issue 12996003: Dynamically generate a heading for Extension Docs API pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/local_renderer.py

Issue 12996003: Dynamically generate a heading for Extension Docs API pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revisions, Offline/Online Access (bypassed-hooks) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/intro_data_source_test.py ('K') | « chrome/common/extensions/docs/server2/intro_data_source_test.py ('k') | chrome/common/extensions/docs/server2/path_canonicalizer.py » ('j') | chrome/common/extensions/docs/server2/render_servlet_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/local_renderer.py

diff --git a/chrome/common/extensions/docs/server2/local_renderer.py b/chrome/common/extensions/docs/server2/local_renderer.py

index 146b0d5dffd100b3cf8bcf7b21ee0e199f792c18..7819e12758a462f10fc8f8a4c4e71dbc3b3d1d3d 100644

--- a/chrome/common/extensions/docs/server2/local_renderer.py

+++ b/chrome/common/extensions/docs/server2/local_renderer.py

@@ -18,7 +18,7 @@ class LocalRenderer(object):

'''

@staticmethod

def Render(path):

- assert not path.contains('\\')

+ assert not '\\' in path

epeterson 2013/05/13 02:38:10 This should probably just be put in its own patch

not at google - send to devlin 2013/05/13 21:26:41 yeah it's been fixed now, you can revert it

def render_path(path):

return RenderServlet(Request(path, 'http://localhost', {}),

_LocalRenderServletDelegate(),