chrome/common/extensions/docs/server2/template_data_source_test.py - Issue 12996003: Dynamically generate a heading for Extension Docs API pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/template_data_source_test.py

Issue 12996003: Dynamically generate a heading for Extension Docs API pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor changes Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/server_instance.py ('K') | « chrome/common/extensions/docs/server2/server_instance.py ('k') | chrome/common/extensions/docs/server2/test_data/availability_data_source/test_avail_branch_list.json » ('j') | chrome/common/extensions/docs/templates/intros/alarms.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/template_data_source_test.py

diff --git a/chrome/common/extensions/docs/server2/template_data_source_test.py b/chrome/common/extensions/docs/server2/template_data_source_test.py

index 9a5d438725d00b406b1f919829abfd619d6385d6..6f33b74b51bcdb54c5779235a13c2f58c59e51a6 100755

--- a/chrome/common/extensions/docs/server2/template_data_source_test.py

+++ b/chrome/common/extensions/docs/server2/template_data_source_test.py

@@ -52,8 +52,12 @@ class TemplateDataSourceTest(unittest.TestCase):

data_source.Render(template_name))

def _CreateTemplateDataSource(self, compiled_fs_factory, api_data=None):

+ fake_avail_factory = _FakeFactory()

not at google - send to devlin 2013/04/30 18:34:19 inline

epeterson 2013/05/13 02:38:10 Done.

if api_data is None:

- api_data_factory = APIDataSource.Factory(compiled_fs_factory, 'fake_path')

+ api_data_factory = APIDataSource.Factory(compiled_fs_factory,

+ 'fake_path',

+ fake_avail_factory,

+ {}) # Unnecessary file system

not at google - send to devlin 2013/04/30 18:34:19 just create a TestFileSystem and avoid the comment

epeterson 2013/05/13 02:38:10 Done.

else:

api_data_factory = _FakeFactory(api_data)

reference_resolver_factory = ReferenceResolver.Factory(