chrome/common/extensions/docs/templates/json/api_availabilities.json - Issue 12996003: Dynamically generate a heading for Extension Docs API pages

Side by Side Diff: chrome/common/extensions/docs/templates/json/api_availabilities.json

Issue 12996003: Dynamically generate a heading for Extension Docs API pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finding earliest 'stable' availability using features files Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/server2/compiled_file_system.py ('K') | « chrome/common/extensions/docs/templates/intros/windows.html ('k') | chrome/common/extensions/docs/templates/json/intro_tables.json » ('j') | chrome/common/extensions/docs/templates/json/intro_tables.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "idle" : "6",

	3 "contextMenus" : "6",

	4 "tts" : "14",

	5 "webstore" : "15"

	6 }
	not at google - send to devlin 2013/04/27 01:48:34 nice! I'm curious, what's preventing these APIs fr nice! I'm curious, what's preventing these APIs from being detected, particularly contextMenus? (and ... how are you determining the old ones?) epeterson 2013/04/27 23:17:23 Definitely take a look at how I'm using the _permi Show quoted text On 2013/04/27 01:48:34, kalman wrote: > nice! I'm curious, what's preventing these APIs from being detected, > particularly contextMenus? > > (and ... how are you determining the old ones?) Definitely take a look at how I'm using the _permission_features.json and _manifest_features.json files in availability_data_source when you get the chance. These features files are only present until version 19 (although _permission_features lacks the "channel" key for APIs, so I'm only going to version 20). Version 18 doesn't have either of these files, only individual API schemas. From version 17 down to version 5, the extension_api.json file contains namespaces for each API. I was looking at possibly using this to generate availability for older APIs. It would work for idle, contextMenus, tts (webstore is weird, though.. there's only webstorePrivate in the pre-18 versions), as well as changing availability for APIs like tabs or windows from the current "20" to a more accurate "5." So, in summary, versions 20+ is what this patch currently handles version 19 is a special case version 18 is also a special case versions 17-5 have extension_api.json files which could be used to find availability for older APIs not at google - send to devlin 2013/04/30 17:20:30 My comment was more that contextMenus seems no mor Show quoted text On 2013/04/27 23:17:23, epeterson wrote: > On 2013/04/27 01:48:34, kalman wrote: > > nice! I'm curious, what's preventing these APIs from being detected, > > particularly contextMenus? > > > > (and ... how are you determining the old ones?) > > Definitely take a look at how I'm using the _permission_features.json and > _manifest_features.json files in availability_data_source when you get the > chance. > > These features files are only present until version 19 (although > _permission_features lacks the "channel" key for APIs, so I'm only going to > version 20). > > Version 18 doesn't have either of these files, only individual API schemas. > > From version 17 down to version 5, the extension_api.json file contains > namespaces for each API. I was looking at possibly using this to generate > availability for older APIs. It would work for idle, contextMenus, tts (webstore > is weird, though.. there's only webstorePrivate in the pre-18 versions), as well > as changing availability for APIs like tabs or windows from the current "20" to > a more accurate "5." > > So, in summary, > versions 20+ is what this patch currently handles > version 19 is a special case > version 18 is also a special case > versions 17-5 have extension_api.json files which could be used to find > availability for older APIs My comment was more that contextMenus seems no more special-casey than say tabs or windows. I'm wondering what makes it necessary to specify this. Ah - and now I see, I presume it's because contextMenus.html contains version 6 manually. Yep. I think, unfortunately, it will be tricky to push this patch since tabs will show up as version 20. If it's not too much trouble, going to back to when the APIs were added to extension_api.json would be nice... then again, it's (a) never going to change and (b) will introduce some extra work (... if one-off) for the server and (c) is probably going to be slower than just going back and figuring out what changes between each version. Actually... (c) I'm not so sure. I'll let you be the judge.
OLD	NEW