Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1299593003: Remove obsolete seccomp_unwinder for legacy (pre-BPF) sandbox (Closed)

Created:
5 years, 4 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 4 months ago
CC:
google-breakpad-dev_googlegroups.com, Robert Sesek, Mark Seaborn, mdempsky
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove obsolete seccomp_unwinder for legacy (pre-BPF) sandbox The PopSeccompStackFrame was introduced to deal with stack frames originated in the legacy seccomp sandbox. The only user of that sandbox was Google Chrome, but the legacy sandbox has been deprecated in 2013 (crrev.com/1290643003) in favor of the new bpf sandbox. Removing this dead code as it has some small bound checking bug which causes occasional crashes in WebView (which are totally unrelated to the sandbox). Note: this will require a corresponding change in the chromium GYP/GN build files to roll. BUG=665, chromium:477444 R=jln@chromium.org, mark@chromium.org, torne@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1492

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -224 lines) Patch
M Makefile.am View 2 chunks +0 lines, -2 lines 0 comments Download
M Makefile.in View 6 chunks +0 lines, -8 lines 0 comments Download
D src/client/linux/dump_writer_common/seccomp_unwinder.h View 1 chunk +0 lines, -50 lines 0 comments Download
D src/client/linux/dump_writer_common/seccomp_unwinder.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M src/client/linux/microdump_writer/microdump_writer.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.cc View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Primiano Tucci (use gerrit)
PTAL. Removing entire translation units is the best way to fix bugs :) See https://code.google.com/p/google-breakpad/issues/detail?id=665&q=PopSeccompStackFrame ...
5 years, 4 months ago (2015-08-17 11:04:26 UTC) #2
Torne
lgtm
5 years, 4 months ago (2015-08-17 11:08:15 UTC) #3
Mark Mentovai
jln to triple-check, but LGTM.
5 years, 4 months ago (2015-08-17 14:19:28 UTC) #5
jln (very slow on Chromium)
lgtm, +mdempsky FYI
5 years, 4 months ago (2015-08-17 17:06:41 UTC) #6
Primiano Tucci (use gerrit)
5 years, 4 months ago (2015-08-18 08:38:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 1492 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698