Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1299563003: Remove grab-bag includes of v8.h from architecture ports. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove grab-bag includes of v8.h from architecture ports. R=yangguo@chromium.org Committed: https://crrev.com/25ee6d666cbfbfada61a7b52ed1107b074cbcce7 Cr-Commit-Position: refs/heads/master@{#30187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -234 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/constants-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/cpu-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/frames-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/cpu-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/decoder-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/delayed-masm-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/deoptimizer-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/disasm-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/frames-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/instructions-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/lithium-gap-resolver-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/disasm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/cpu-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/frames-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/lithium-gap-resolver-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/constants-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/cpu-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/disasm-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/frames-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/lithium-gap-resolver-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/constants-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/cpu-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/frames-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/lithium-gap-resolver-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/constants-ppc.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ppc/constants-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/cpu-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/deoptimizer-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/frames-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/lithium-gap-resolver-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/cpu-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/frames-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/codegen-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/cpu-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/disasm-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/frames-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/lithium-gap-resolver-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-17 09:17:13 UTC) #1
Yang
On 2015/08/17 09:17:13, Michael Starzinger wrote: lgtm
5 years, 4 months ago (2015-08-17 09:27:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299563003/1
5 years, 4 months ago (2015-08-17 09:31:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 09:42:34 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 09:42:47 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/25ee6d666cbfbfada61a7b52ed1107b074cbcce7
Cr-Commit-Position: refs/heads/master@{#30187}

Powered by Google App Engine
This is Rietveld 408576698