Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1299543005: Allow enable_hangout_services_extension overriding in gn build (Closed)

Created:
5 years, 4 months ago by mmal
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow enable_hangout_services_extension overriding in gn build BUG= Committed: https://crrev.com/efefbb817804457c48c388db8e96241d528d20ff Cr-Commit-Position: refs/heads/master@{#343871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build/config/features.gni View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mmal
PTAL
5 years, 4 months ago (2015-08-17 10:53:41 UTC) #2
brettw
lgtm
5 years, 4 months ago (2015-08-17 22:30:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543005/1
5 years, 4 months ago (2015-08-18 09:20:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 09:57:00 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 09:57:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efefbb817804457c48c388db8e96241d528d20ff
Cr-Commit-Position: refs/heads/master@{#343871}

Powered by Google App Engine
This is Rietveld 408576698