Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1299543002: Delete dead signin code (SigninGlobalError) (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete dead signin code (SigninGlobalError) BUG=none Committed: https://crrev.com/c91b178b07b0d9fb0c7a437df3a1da3db1887160 Cr-Commit-Position: refs/heads/master@{#344176}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : mac and tests #

Patch Set 4 : mac #

Patch Set 5 : fix GN #

Patch Set 6 : . #

Patch Set 7 : fix mac test #

Patch Set 8 : fix mac? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -986 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/app_controller_mac.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 2 5 chunks +0 lines, -58 lines 0 comments Download
M chrome/browser/app_controller_mac_unittest.mm View 1 2 3 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/browser/signin/signin_global_error.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/signin/signin_global_error.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/browser/signin/signin_global_error_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/signin/signin_global_error_factory.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/signin/signin_global_error_unittest.cc View 1 2 1 chunk +0 lines, -170 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 2 chunks +0 lines, -67 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 7 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/ui/browser_command_controller_unittest.cc View 1 2 4 chunks +0 lines, -35 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm View 1 2 3 4 5 6 7 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 8 chunks +2 lines, -69 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 37 (17 generated)
Evan Stade
Hi Anthony and Scott, I started down this rabbit hole because I was trying to ...
5 years, 4 months ago (2015-08-14 22:45:07 UTC) #2
sky
LGTM - but wait for Anthony as I don't know the subtleties of what needs ...
5 years, 4 months ago (2015-08-14 22:58:50 UTC) #3
anthonyvd
lgtm, +rogerta who's a lot more knowledgeable of signin than I am to confirm. Thanks ...
5 years, 4 months ago (2015-08-17 14:16:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543002/20001
5 years, 4 months ago (2015-08-17 17:14:37 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/103786) android_chromium_gn_compile_rel on ...
5 years, 4 months ago (2015-08-17 17:17:59 UTC) #9
Roger Tawa OOO till Jul 10th
lgtm Great cleanup Evan, thanks! Can you just double check that if you sign in ...
5 years, 4 months ago (2015-08-18 12:36:37 UTC) #10
Evan Stade
On 2015/08/18 12:36:37, Roger Tawa wrote: > lgtm > > Great cleanup Evan, thanks! > ...
5 years, 4 months ago (2015-08-18 14:21:14 UTC) #11
Roger Tawa OOO till Jul 10th
Cool, thanks for checking. Thanks, Roger - On Tue, Aug 18, 2015 at 10:21 AM, ...
5 years, 4 months ago (2015-08-18 15:45:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543002/60001
5 years, 4 months ago (2015-08-18 17:10:30 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/121107)
5 years, 4 months ago (2015-08-18 17:14:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543002/100001
5 years, 4 months ago (2015-08-18 20:46:57 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/86733)
5 years, 4 months ago (2015-08-18 21:12:24 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543002/120001
5 years, 4 months ago (2015-08-18 21:54:06 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/100611)
5 years, 4 months ago (2015-08-18 22:21:10 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543002/140001
5 years, 4 months ago (2015-08-18 23:14:52 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94980)
5 years, 4 months ago (2015-08-19 00:04:23 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299543002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299543002/140001
5 years, 4 months ago (2015-08-19 06:21:29 UTC) #34
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 4 months ago (2015-08-19 07:53:21 UTC) #35
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/c91b178b07b0d9fb0c7a437df3a1da3db1887160 Cr-Commit-Position: refs/heads/master@{#344176}
5 years, 4 months ago (2015-08-19 07:54:12 UTC) #36
Adam Rice
5 years, 4 months ago (2015-08-19 09:30:48 UTC) #37
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1301583004/ by ricea@chromium.org.

The reason for reverting is: Broke the Mac10.9 Tests (dbg) bot:

http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29...

See the stack trace in the logs..

Powered by Google App Engine
This is Rietveld 408576698