Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: chrome/browser/android/hung_renderer_infobar_delegate.cc

Issue 1299513002: [Android] Add support for a hung renderer dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: New resources, UMA, cleanup, etc... Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/hung_renderer_infobar_delegate.cc
diff --git a/chrome/browser/android/hung_renderer_infobar_delegate.cc b/chrome/browser/android/hung_renderer_infobar_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7e711289d8955a7a14766fa06a5d1f45605bc9fb
--- /dev/null
+++ b/chrome/browser/android/hung_renderer_infobar_delegate.cc
@@ -0,0 +1,81 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/hung_renderer_infobar_delegate.h"
+
+#include "base/callback.h"
+#include "base/metrics/histogram.h"
+#include "base/metrics/user_metrics.h"
+#include "chrome/grit/generated_resources.h"
+#include "components/infobars/core/infobar.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/common/result_codes.h"
+#include "grit/theme_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+HungRendererInfoBarDelegate::HungRendererInfoBarDelegate(
+ content::WebContents* web_contents)
+ : web_contents_(web_contents), action_logged_for_uma_(false) {
+ DCHECK(web_contents);
+}
+
+HungRendererInfoBarDelegate::~HungRendererInfoBarDelegate() {
+ LogAction(REMOVE);
+}
+
+void HungRendererInfoBarDelegate::InfoBarDismissed() {
+ LogAction(DISMISS);
+}
+
+HungRendererInfoBarDelegate*
+HungRendererInfoBarDelegate::AsHungRendererInfoBarDelegate() {
+ return this;
+}
+
+int HungRendererInfoBarDelegate::GetIconID() const {
+ return IDR_INFOBAR_FROZEN_TAB;
+}
+
+base::string16 HungRendererInfoBarDelegate::GetMessageText() const {
+ return l10n_util::GetPluralStringFUTF16(IDS_BROWSER_HANGMONITOR_RENDERER, 1);
+}
+
+base::string16 HungRendererInfoBarDelegate::GetButtonLabel(
+ InfoBarButton button) const {
+ return l10n_util::GetStringUTF16((button == BUTTON_OK)
+ ? IDS_BROWSER_HANGMONITOR_RENDERER_END
+ : IDS_BROWSER_HANGMONITOR_RENDERER_WAIT);
+}
+
+bool HungRendererInfoBarDelegate::Accept() {
+ LogAction(KILL);
+ content::RenderProcessHost* process = web_contents_->GetRenderProcessHost();
+ process->Shutdown(content::RESULT_CODE_HUNG, false);
+ return true;
+}
+
+bool HungRendererInfoBarDelegate::Cancel() {
+ LogAction(WAIT);
+ return true;
+}
+
+void HungRendererInfoBarDelegate::OnRendererResponsive() {
+ LogAction(RESPONSIVE);
+}
+
+void HungRendererInfoBarDelegate::LogAction(Action action) {
+ if (action_logged_for_uma_)
+ return;
+
+ action_logged_for_uma_ = true;
+
+ UMA_HISTOGRAM_ENUMERATION("HungRenderer.MobileInfoBar.Action", action,
+ ACTION_COUNT);
+
+ if (action == KILL) {
+ base::RecordAction(
+ base::UserMetricsAction("MobileHungRendererInfoBarKill"));
gone 2015/09/01 18:49:34 Any reason you're doubling up on the count and his
jdduke (slow) 2015/09/01 21:49:20 Yeah, I thought it might be nice to have this incl
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698