[Android] Add support for a hung renderer dialog

chrome/browser/android/hung_renderer_infobar_delegate.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_HUNG_RENDERER_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_ANDROID_HUNG_RENDERER_INFOBAR_DELEGATE_H_
+
+#include "components/infobars/core/confirm_infobar_delegate.h"
+
+namespace content {
+class WebContent;
+}
+
+// This class is responsible for customizing a hung renderer infobar.

[Peter Kasting, 2015/09/01 22:24:05]

Nit: "customizing"?  That sounds as if there's already some concept of a hung
renderer infobar and you're tweaking it.  How about something like:

An infobar shown when a tab's renderer is hung.  <Further description of how
this looks and how user interacts with it>

[jdduke (slow), 2015/09/02 00:04:01]

Done.

+// If the "kill" dialog is clicked, the renderer of the corresponding

[Peter Kasting, 2015/09/01 22:24:05]

Nit: Did you mean "button" instead of "dialog"?

[jdduke (slow), 2015/09/02 00:04:01]

Yeah, rephrased in the new comment.

+// WebContents will be shutdown.

[Peter Kasting, 2015/09/01 22:24:05]

Nit: shut down (shutdown is a noun)

[jdduke (slow), 2015/09/02 00:04:01]

Yeah, also removed in the new phrasing.

+class HungRendererInfoBarDelegate : public ConfirmInfoBarDelegate {
+ public:

[Peter Kasting, 2015/09/01 22:24:05]

Almost none of this stuff should be public.  You should instead have a public
static Create() function that can create the infobar and delegate and add it to
an infobar service.  Look at how all other infobars in the codebase work.

[jdduke (slow), 2015/09/02 00:04:01]

Done.

+  // The caller must ensure that |web_contents| outlives the delegate.
+  // This will naturally occur if the associated InfoBar is managed by the
+  // InfoBarService.
+  explicit HungRendererInfoBarDelegate(content::WebContents* web_contents);
+  ~HungRendererInfoBarDelegate() override;
+
+  // InfoBarDelegate:

[Peter Kasting, 2015/09/01 22:24:05]

You don't directly subclass InfoBarDelegate, so these should be in the
ConfirmInfoBarDelegate section.

[jdduke (slow), 2015/09/02 00:04:01]

Done.

+  void InfoBarDismissed() override;
+  HungRendererInfoBarDelegate* AsHungRendererInfoBarDelegate() override;
+
+  // ConfirmInfoBarDelegate:
+  int GetIconID() const override;
+  base::string16 GetMessageText() const override;
+  base::string16 GetButtonLabel(InfoBarButton button) const override;
+  bool Accept() override;
+  bool Cancel() override;
+
+  // Called when the renderer regains responsiveness before the dialog is

[Peter Kasting, 2015/09/01 22:24:05]

Nit: when -> if?

[jdduke (slow), 2015/09/02 00:04:01]

Done.

+  // dismissed.
+  void OnRendererResponsive();
+
+ private:
+  // Keep these values in alignment with their histograms.xml counterparts.
+  enum Action { WAIT = 0, KILL, DISMISS, RESPONSIVE, REMOVE, ACTION_COUNT };

[Peter Kasting, 2015/09/01 22:24:05]

Nit: RESPONSIVE is not an action.  Perhaps you meant "Event" rather than
"Action" and wanted to name your events something like:

WAIT_CLICKED
KILL_CLICKED
INFOBAR_DISMISSED
RENDERER_BECAME_RESPONSIVE

[jdduke (slow), 2015/09/02 00:04:01]

I thought of using RESULT, as we'd really like just one per infobar. Event
works.

+  void LogAction(Action action);
+
+  content::WebContents* web_contents_;
+
+  bool action_logged_for_uma_;
+
+  DISALLOW_COPY_AND_ASSIGN(HungRendererInfoBarDelegate);
+};
+
+#endif  // CHROME_BROWSER_ANDROID_HUNG_RENDERER_INFOBAR_DELEGATE_H_