chrome/browser/ui/cocoa/download/download_shelf_mac.mm - Issue 12995025: [Mac] DownloadShelf should be notified when autoclosing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_mac.mm

Issue 12995025: [Mac] DownloadShelf should be notified when autoclosing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Undo re-ordering. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/download/download_shelf_mac.mm

diff --git a/chrome/browser/ui/cocoa/download/download_shelf_mac.mm b/chrome/browser/ui/cocoa/download/download_shelf_mac.mm

index c644b51927b12346f08f61722b477d7ac36773ab..cd21a384dd8125f8b7cacc68cef6b3b5913b89d6 100644

--- a/chrome/browser/ui/cocoa/download/download_shelf_mac.mm

+++ b/chrome/browser/ui/cocoa/download/download_shelf_mac.mm

@@ -29,12 +29,14 @@ bool DownloadShelfMac::IsClosing() const {

}

void DownloadShelfMac::DoShow() {

- [shelf_controller_ show:nil];

+ [shelf_controller_ showDownloadShelf:YES

+ isUserAction:NO];

browser_->UpdateDownloadShelfVisibility(true);

}

-void DownloadShelfMac::DoClose() {

- [shelf_controller_ hide:nil];

+void DownloadShelfMac::DoClose(CloseReason reason) {

+ [shelf_controller_ showDownloadShelf:NO

+ isUserAction:reason == USER_ACTION];

browser_->UpdateDownloadShelfVisibility(false);

}