chrome/browser/ui/chrome_pages.cc - Issue 12995025: [Mac] DownloadShelf should be notified when autoclosing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 12995025: [Mac] DownloadShelf should be notified when autoclosing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Undo re-ordering. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/chrome_pages.cc

diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc

index 8d842647a0d64604dbe5f6a463a13ea5de4ed67e..79e948e8f6e18f4c68e66e3c551a92bbaf1262dc 100644

--- a/chrome/browser/ui/chrome_pages.cc

+++ b/chrome/browser/ui/chrome_pages.cc

@@ -87,8 +87,9 @@ void ShowDownloads(Browser* browser) {

content::RecordAction(UserMetricsAction("ShowDownloads"));

if (browser->window()) {

DownloadShelf* shelf = browser->window()->GetDownloadShelf();

+ // The downloads page is always shown in response to a user action.

if (shelf->IsShowing())

- shelf->Close();

+ shelf->Close(DownloadShelf::USER_ACTION);

}

ShowSingletonTabOverwritingNTP(

browser,