Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_mac.mm

Issue 12995025: [Mac] DownloadShelf should be notified when autoclosing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/download/download_shelf_controller.mm ('K') | « chrome/browser/ui/cocoa/download/download_shelf_mac.h ('k') | chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm » ('j') | chrome/browser/ui/gtk/download/download_shelf_gtk.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/download/download_shelf_mac.mm
diff --git a/chrome/browser/ui/cocoa/download/download_shelf_mac.mm b/chrome/browser/ui/cocoa/download/download_shelf_mac.mm
index c644b51927b12346f08f61722b477d7ac36773ab..f0bcb0a5d4b046428c2c986d13bcdf4bc792b0d5 100644
--- a/chrome/browser/ui/cocoa/download/download_shelf_mac.mm
+++ b/chrome/browser/ui/cocoa/download/download_shelf_mac.mm
@@ -29,12 +29,14 @@ bool DownloadShelfMac::IsClosing() const {
}
void DownloadShelfMac::DoShow() {
- [shelf_controller_ show:nil];
+ [shelf_controller_ showDownloadShelf:YES
+ isUserAction:NO];
browser_->UpdateDownloadShelfVisibility(true);
}
-void DownloadShelfMac::DoClose() {
- [shelf_controller_ hide:nil];
+void DownloadShelfMac::DoClose(CloseReason reason) {
+ [shelf_controller_ showDownloadShelf:NO
+ isUserAction:(reason == USER_ACTION)];
Nico 2013/03/22 20:24:11 nit: ne need for the parens
asanka 2013/03/22 21:22:13 Done.
browser_->UpdateDownloadShelfVisibility(false);
}
« chrome/browser/ui/cocoa/download/download_shelf_controller.mm ('K') | « chrome/browser/ui/cocoa/download/download_shelf_mac.h ('k') | chrome/browser/ui/cocoa/download/download_shelf_mac_unittest.mm » ('j') | chrome/browser/ui/gtk/download/download_shelf_gtk.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698