Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 12995022: Update stack map computation to match the way XMM registers are spilled on the slow path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1310 matching lines...) Expand 10 before | Expand all | Expand 10 after
1321 __ Drop(1); 1321 __ Drop(1);
1322 __ jmp(skip_call); 1322 __ jmp(skip_call);
1323 __ Bind(&is_false); 1323 __ Bind(&is_false);
1324 __ LoadObject(result, Bool::False()); 1324 __ LoadObject(result, Bool::False());
1325 __ Drop(1); 1325 __ Drop(1);
1326 __ jmp(skip_call); 1326 __ jmp(skip_call);
1327 __ Bind(&fall_through); 1327 __ Bind(&fall_through);
1328 } 1328 }
1329 1329
1330 1330
1331 // This function must be in sync with FlowGraphCompiler::RecordSafepoint.
1331 void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) { 1332 void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) {
1332 // TODO(vegorov): consider saving only caller save (volatile) registers. 1333 // TODO(vegorov): consider saving only caller save (volatile) registers.
1333 const intptr_t xmm_regs_count = locs->live_registers()->fpu_regs_count(); 1334 const intptr_t xmm_regs_count = locs->live_registers()->fpu_regs_count();
1334 if (xmm_regs_count > 0) { 1335 if (xmm_regs_count > 0) {
1335 __ subl(ESP, Immediate(xmm_regs_count * kFpuRegisterSize)); 1336 __ subl(ESP, Immediate(xmm_regs_count * kFpuRegisterSize));
1336 // Store XMM registers with the lowest register number at the lowest 1337 // Store XMM registers with the lowest register number at the lowest
1337 // address. 1338 // address.
1338 intptr_t offset = 0; 1339 intptr_t offset = 0;
1339 for (intptr_t reg_idx = 0; reg_idx < kNumberOfXmmRegisters; ++reg_idx) { 1340 for (intptr_t reg_idx = 0; reg_idx < kNumberOfXmmRegisters; ++reg_idx) {
1340 XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx); 1341 XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx);
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
1714 __ popl(ECX); 1715 __ popl(ECX);
1715 __ popl(EAX); 1716 __ popl(EAX);
1716 } 1717 }
1717 1718
1718 1719
1719 #undef __ 1720 #undef __
1720 1721
1721 } // namespace dart 1722 } // namespace dart
1722 1723
1723 #endif // defined TARGET_ARCH_IA32 1724 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698