Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: runtime/vm/service.h

Issue 1299493007: Rework service extensions to be safe (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/json_stream.h ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.h
diff --git a/runtime/vm/service.h b/runtime/vm/service.h
index 0c51c729a2110740b2e999762bedae1a2383819b..4e4ccd24099d4f0d7e13bb4c8a69e2be809a74ab 100644
--- a/runtime/vm/service.h
+++ b/runtime/vm/service.h
@@ -15,6 +15,7 @@ namespace dart {
class Array;
class EmbedderServiceHandler;
+class Error;
class GCEvent;
class GrowableObjectArray;
class Instance;
@@ -120,6 +121,13 @@ class Service : public AllStatic {
const Object& error,
const Instance& stack_trace);
+ static void PostError(const String& method_name,
+ const Array& parameter_keys,
+ const Array& parameter_values,
+ const Instance& reply_port,
+ const Instance& id,
+ const Error& error);
+
// Well-known streams.
static StreamInfo isolate_stream;
static StreamInfo debug_stream;
@@ -146,7 +154,8 @@ class Service : public AllStatic {
static EmbedderServiceHandler* FindIsolateEmbedderHandler(const char* name);
static EmbedderServiceHandler* FindRootEmbedderHandler(const char* name);
- static bool ScheduleExtensionHandler(const String& name,
+ static void ScheduleExtensionHandler(const Instance& handler,
+ const String& method_name,
const Array& parameter_keys,
const Array& parameter_values,
const Instance& reply_port,
« no previous file with comments | « runtime/vm/json_stream.h ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698