Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1299493005: Avoid scaling a zero-sized image (Closed)

Created:
5 years, 4 months ago by Yoav Weiss
Modified:
5 years, 4 months ago
Reviewers:
pdr., jsbell
CC:
blink-reviews, blink-reviews-rendering, blink-reviews-w3ctests_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid scaling a zero-sized image Since scaling a zero-sized image can result in dealing with NaNs (in case that we're scaling it using an inf, which is fairly possible), we should avoid doing that. This CL makes sure that we do. As to why we're dealing with zero sized images to begin with, I've opened crbug.com/522637, but it seems like something that can happen regardless, when ImageResource doesn't have an Image. BUG=521954 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200879

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute-expected.txt View 1 chunk +411 lines, -1 line 1 comment Download
M Source/core/layout/LayoutImageResource.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Yoav Weiss
Hey Philip :) Can you please take a look? This CL makes sure that even ...
5 years, 4 months ago (2015-08-19 22:04:38 UTC) #2
Yoav Weiss
https://codereview.chromium.org/1299493005/diff/20001/LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute-expected.txt File LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute-expected.txt (right): https://codereview.chromium.org/1299493005/diff/20001/LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute-expected.txt#newcode528 LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute-expected.txt:528: FAIL "data:,a 1.x" assert_equals: expected "" but got "data:,a" ...
5 years, 4 months ago (2015-08-19 22:09:57 UTC) #3
jsbell
drive-by lgtm on the imported/web-platform-test changes
5 years, 4 months ago (2015-08-19 22:22:31 UTC) #5
pdr.
LGTM
5 years, 4 months ago (2015-08-20 05:22:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299493005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299493005/20001
5 years, 4 months ago (2015-08-20 05:34:35 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 06:38:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200879

Powered by Google App Engine
This is Rietveld 408576698