Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1299493004: Revert of Add a library for running external commands, providing timeouts and test injection. (Closed)

Created:
5 years, 4 months ago by rmistry
Modified:
5 years, 4 months ago
Reviewers:
jcgregorio, dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Add a library for running external commands, providing timeouts and test injection. (patchset #2 id:140001 of https://codereview.chromium.org/1302513006/ ) Reason for revert: CT Perf tasks are immediately failing: https://uberchromegw.corp.google.com/i/skia-ct-master/run_chromium_perf_on_workers.build101-m5.chrome-bot.log.INFO.20150819-130840.6185 It is likely unrelated to this CL but I am going to try reverting it and rerunning to see what happens. Original issue's description: > Reland of Add a library for running external commands, providing timeouts and test injection. (patchset #1 id:1 of https://codereview.chromium.org/1295043002/ ) > > Reason for revert: > Fixed bug in original code - see patchset #2. > > Original issue's description: > > Revert of Add a library for running external commands, providing timeouts and test injection. (patchset #2 id:40001 of https://codereview.chromium.org/1290913004/ ) > > > > Reason for revert: > > CT Chromium Perf tasks are failing with: > > > > E0815 11:07:22.649344 13091 exec.go:193] Command exited with invalid argument: python /b/skia-repo/go/src/go.skia.org/infra/ct/py/sync_skia_in_chrome.py --destination=/b/storage/chromium_builds/linux_base --fetch_target=chromium --chrome_revision=6ae54795f6d077e31f4fb42540ead46f4141f2bb --skia_revision=fb28cd2b13d76c324570341e1155aaadc1b532b6 > > > > Original issue's description: > > > Add a library for running external commands, providing timeouts and test injection. > > > > > > BUG=skia:4106 > > > > > > Committed: https://skia.googlesource.com/buildbot/+/b65fde6749a3e060938cd280c7e281e29516edc1 > > > > TBR=jcgregorio@google.com,benjaminwagner@google.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia:4106 > > > > Committed: https://skia.googlesource.com/buildbot/+/ac6c1292955c888d35f6c01cf97d3b6ff4029424 > > BUG=skia:4106 > > Committed: https://skia.googlesource.com/buildbot/+/a12e89205d4145b4da14b0a7d5b95b15b029ada9 TBR=jcgregorio@google.com,benjaminwagner@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4106 Committed: https://skia.googlesource.com/buildbot/+/0a44649b05aa6f864a45268f681f88328f93796d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -547 lines) Patch
M ct/go/adb/adb.go View 3 chunks +4 lines, -3 lines 0 comments Download
M ct/go/util/util.go View 2 chunks +59 lines, -17 lines 0 comments Download
D go/exec/exec.go View 1 chunk +0 lines, -235 lines 0 comments Download
D go/exec/exec_test.go View 1 chunk +0 lines, -289 lines 0 comments Download
M go/util/command.go View 1 chunk +22 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmistry
Created Revert of Add a library for running external commands, providing timeouts and test injection.
5 years, 4 months ago (2015-08-19 20:11:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299493004/1
5 years, 4 months ago (2015-08-19 20:11:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/buildbot/+/0a44649b05aa6f864a45268f681f88328f93796d
5 years, 4 months ago (2015-08-19 20:11:57 UTC) #3
dogben
5 years, 4 months ago (2015-08-20 01:59:28 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1300273002/ by benjaminwagner@google.com.

The reason for reverting is: Reland after fix..

Powered by Google App Engine
This is Rietveld 408576698