Source/core/loader/BeaconLoader.cpp - Issue 1299493003: Attach mixed content status to resource requests when sent to devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/BeaconLoader.cpp

Issue 1299493003: Attach mixed content status to resource requests when sent to devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: isMixedContent() -> ContextTypeNotMixedContent, and rename devtools protocol enum Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InspectorResourceAgent.cpp ('K') | « Source/core/inspector/InspectorResourceAgent.cpp ('k') | Source/core/loader/FrameFetchContext.h » ('j') | Source/core/loader/MixedContentChecker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/BeaconLoader.cpp

diff --git a/Source/core/loader/BeaconLoader.cpp b/Source/core/loader/BeaconLoader.cpp

index b12dc62b51d6c09557628211e589bde3b24b56ff..55181725605a3d932cb2465012679ac061a8380f 100644

--- a/Source/core/loader/BeaconLoader.cpp

+++ b/Source/core/loader/BeaconLoader.cpp

@@ -88,7 +88,7 @@ public:

frame->document()->fetcher()->context().addAdditionalRequestHeaders(request, FetchSubresource);

frame->document()->fetcher()->context().setFirstPartyForCookies(request);

- if (MixedContentChecker::shouldBlockFetch(frame, request, request.url()))

+ if (MixedContentChecker::shouldBlockFetch(frame, &request, request.url()))

return false;

payloadLength = entitySize;