Source/core/loader/PingLoader.cpp - Issue 1299493003: Attach mixed content status to resource requests when sent to devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/PingLoader.cpp

Issue 1299493003: Attach mixed content status to resource requests when sent to devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/loader/MixedContentChecker.h ('K') | « Source/core/loader/MixedContentChecker.cpp ('k') | Source/devtools/protocol.json » ('j') | Source/platform/network/ResourceRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/PingLoader.cpp

diff --git a/Source/core/loader/PingLoader.cpp b/Source/core/loader/PingLoader.cpp

index d0b669fb8c9efd825ac6e7746173d420ee0568e4..a134b19160e1759180f9810535232dcece3902bf 100644

--- a/Source/core/loader/PingLoader.cpp

+++ b/Source/core/loader/PingLoader.cpp

@@ -125,7 +125,7 @@ void PingLoader::sendViolationReport(LocalFrame* frame, const KURL& reportURL, P

void PingLoader::start(LocalFrame* frame, ResourceRequest& request, const FetchInitiatorInfo& initiatorInfo, StoredCredentials credentialsAllowed)

{

- if (MixedContentChecker::shouldBlockFetch(frame, request, request.url()))

+ if (MixedContentChecker::shouldBlockFetch(frame, &request, request.url()))

return;

// Leak the ping loader, since it will kill itself as soon as it receives a response.

« Source/core/loader/MixedContentChecker.h ('K') | « Source/core/loader/MixedContentChecker.cpp ('k') | Source/devtools/protocol.json » ('j') | Source/platform/network/ResourceRequest.h » ('J')