LayoutTests/http/tests/inspector-protocol/request-mixed-content-status.html - Issue 1299493003: Attach mixed content status to resource requests when sent to devtools

Side by Side Diff: LayoutTests/http/tests/inspector-protocol/request-mixed-content-status.html

Issue 1299493003: Attach mixed content status to resource requests when sent to devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: change to MixedContentChecker::contextTypeForInspector() Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script type="text/javascript" src="../inspector-protocol/inspector-protocol-tes t.js"></script>

	5 <script src="/resources/get-host-info.js"></script>

	6 <script>

	7 if (window.testRunner) {

	8 testRunner.overridePreference("WebKitAllowRunningInsecureContent", true);

	9 testRunner.overridePreference("WebKitAllowDisplayingInsecureContent", true);

	10 }

	11

	12 function noMixedContent()

	13 {

	14 var iframe = document.createElement("iframe");

	15 iframe.src = get_host_info().HTTPS_ORIGIN + "/inspector-protocol/resources/n o-mixed-content-iframe.html";

	16 document.body.appendChild(iframe);

	17 }

	18

	19 function blockableMixedContent()

	20 {

	21 var iframe = document.createElement("iframe");

	22 iframe.src = get_host_info().HTTPS_ORIGIN + "/inspector-protocol/resources/a ctive-mixed-content-iframe.html";

	23 document.body.appendChild(iframe);

	24 }

	25

	26 function optionallyBlockableMixedContent()

	27 {

	28 var iframe = document.createElement("iframe");

	29 iframe.src = get_host_info().HTTPS_ORIGIN + "/inspector-protocol/resources/p assive-mixed-content-iframe.html";

	30 document.body.appendChild(iframe);

	31 }

	32

	33 function test()

	34 {

	35 var expectedMixedContentType = "none";

	36 InspectorTest.eventHandler["Network.requestWillBeSent"] = onRequestWillBeSen t;

	37 InspectorTest.sendCommand("Network.enable", {}, didEnableNetwork);

	38

	39 function didEnableNetwork(messageObject)

	40 {

	41 if (messageObject.error) {

	42 InspectorTest.log("FAIL: Couldn't enable network agent" + messageObj ect.error.message);

	43 InspectorTest.completeTest();

	44 return;

	45 }

	46 InspectorTest.log("Network agent enabled");

	47 InspectorTest.sendCommand("Runtime.evaluate", { "expression": "noMixedCo ntent()" });

	48 }

	49

	50 function onRequestWillBeSent(event) {

	51 var req = event.params.request;

	52 InspectorTest.log(req.url);

	53 if (req.url.indexOf("check-mixed-content-status") === -1)
	pfeldman 2015/08/19 17:10:19 You should dump into the log more aggressively, li You should dump into the log more aggressively, like dump mixedContentType instead of checking its value. estark 2015/08/19 19:07:03 Done. Show quoted text On 2015/08/19 17:10:19, pfeldman wrote: > You should dump into the log more aggressively, like dump mixedContentType > instead of checking its value. Done.
	54 return;

	55

	56 if (req.mixedContentType !== expectedMixedContentType) {

	57 InspectorTest.log("FAIL: expected mixed content " + expectedMixedCon tentType + ", got " + req.mixedContentStatus);

	58 InspectorTest.completeTest();

	59 return;

	60 }

	61

	62 if (expectedMixedContentType == "none") {

	63 expectedMixedContentType = "blockable";

	64 InspectorTest.sendCommand("Runtime.evaluate", { "expression": "block ableMixedContent()" });

	65 } else if (expectedMixedContentType == "blockable") {
	pfeldman 2015/08/19 17:10:19 So this is a small state machine that iterates ove So this is a small state machine that iterates over the scenarios? You should run them in the Runtime.evaluate callbacks instead of checking the content type. estark 2015/08/19 19:07:03 Hmm, I wasn't quite able to get this to work, beca Show quoted text On 2015/08/19 17:10:19, pfeldman wrote: > So this is a small state machine that iterates over the scenarios? You should > run them in the Runtime.evaluate callbacks instead of checking the content type. Hmm, I wasn't quite able to get this to work, because the Runtime.evaluate callback runs before the corresponding onRequestWillBeSent() events fire. I think we need to track something in onRequestWillBeSent() to be able to detect when the test is over and call InspectorTest.notifyComplete(). There was also an additional wrinkle that I couldn't figure out how to access get_host_info().HTTPS_ORIGIN inside a Runtime.evaluate callback. What I did instead was fire off the three scenarios (noMixedContent(), blockableMixedContent(), optionallyBlockableMixedContent()) one after the other, and count the number of requests in onRequestWillBeSent() to know when the test is done. I'm not sure if we can assume that the requests will always come in the same order, though. If not, I think we do have to use onRequestWillBeSent() to trigger the next scenario, since otherwise we won't be able to guarantee that the requests get sent in the expected order. What do you think?
	66 expectedMixedContentType = "optionally-blockable";

	67 InspectorTest.sendCommand("Runtime.evaluate", { "expression": "optio nallyBlockableMixedContent()" });

	68 } else if (expectedMixedContentType == "optionally-blockable") {

	69 InspectorTest.completeTest();

	70 }

	71 }

	72 }

	73

	74 </script>

	75 </head>

	76 <body onload="runTest()">

	77 <p>Tests that willSendRequest contains the correct mixed content status.</p>

	78 </body>

	79 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/inspector-protocol/request-mixed-content-status-expected.txt » ('j') | no next file with comments »