Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1299433002: Pass enable_topchrome_md as a grit define (Closed)

Created:
5 years, 4 months ago by tdanderson
Modified:
5 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass enable_topchrome_md as a grit define Specify enable_topchrome_md as a grit define, which will be used to specify new asset IDs which are only applicable to platforms affected by the material design refresh in browser top chrome. BUG=520992 TEST=none Committed: https://crrev.com/01b7e6102e67d35eb46060f05901f62955ca6e62 Cr-Commit-Position: refs/heads/master@{#343415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tdanderson
Scott, can you please take a look?
5 years, 4 months ago (2015-08-14 15:50:47 UTC) #2
scottmg
lgtm
5 years, 4 months ago (2015-08-14 16:01:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299433002/1
5 years, 4 months ago (2015-08-14 16:06:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 16:58:13 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 16:58:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01b7e6102e67d35eb46060f05901f62955ca6e62
Cr-Commit-Position: refs/heads/master@{#343415}

Powered by Google App Engine
This is Rietveld 408576698