Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 129943002: Move remoting Android targets to separate gypi (Closed)

Created:
6 years, 11 months ago by Lambros
Modified:
6 years, 11 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Move remoting Android targets to separate gypi This pulls Android-specific targets out of remoting.gyp into a new gypi file. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243868

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -141 lines) Patch
M remoting/remoting.gyp View 4 chunks +6 lines, -141 lines 2 comments Download
A remoting/remoting_android.gypi View 1 chunk +143 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lambros
WDYT ? https://codereview.chromium.org/129943002/diff/1/remoting/remoting.gyp File remoting/remoting.gyp (left): https://codereview.chromium.org/129943002/diff/1/remoting/remoting.gyp#oldcode2165 remoting/remoting.gyp:2165: ['exclude', '^client/plugin/'], This was excluding every source ...
6 years, 11 months ago (2014-01-09 00:28:29 UTC) #1
Sergey Ulanov
lgtm
6 years, 11 months ago (2014-01-09 00:49:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/129943002/1
6 years, 11 months ago (2014-01-09 01:06:36 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243870
6 years, 11 months ago (2014-01-09 03:01:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/129943002/1
6 years, 11 months ago (2014-01-09 03:16:30 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:34:12 UTC) #6
Message was sent while issue was closed.
Change committed as 243868

Powered by Google App Engine
This is Rietveld 408576698