Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

Issue 1299413002: Move common identifiers, names and selectors to a separate library. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter.full_emitter; 5 part of dart2js.js_emitter.full_emitter;
6 6
7 class ClassEmitter extends CodeEmitterHelper { 7 class ClassEmitter extends CodeEmitterHelper {
8 8
9 ClassStubGenerator get _stubGenerator => 9 ClassStubGenerator get _stubGenerator =>
10 new ClassStubGenerator(compiler, namer, backend); 10 new ClassStubGenerator(compiler, namer, backend);
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 js('#.prototype.#.${namer.reflectableField} = 1', 415 js('#.prototype.#.${namer.reflectableField} = 1',
416 [className, setterName])); 416 [className, setterName]));
417 } 417 }
418 } 418 }
419 419
420 void generateReflectionDataForFieldGetterOrSetter(Element member, 420 void generateReflectionDataForFieldGetterOrSetter(Element member,
421 jsAst.Name name, 421 jsAst.Name name,
422 ClassBuilder builder, 422 ClassBuilder builder,
423 {bool isGetter}) { 423 {bool isGetter}) {
424 Selector selector = isGetter 424 Selector selector = isGetter
425 ? new Selector.getter(member.name, member.library) 425 ? new Selector.getter(
426 : new Selector.setter(member.name, member.library); 426 new Name(member.name, member.library))
427 : new Selector.setter(
428 new Name(member.name, member.library, isSetter: true));
427 String reflectionName = emitter.getReflectionName(selector, name); 429 String reflectionName = emitter.getReflectionName(selector, name);
428 if (reflectionName != null) { 430 if (reflectionName != null) {
429 var reflectable = 431 var reflectable =
430 js(backend.isAccessibleByReflection(member) ? '1' : '0'); 432 js(backend.isAccessibleByReflection(member) ? '1' : '0');
431 builder.addPropertyByName('+$reflectionName', reflectable); 433 builder.addPropertyByName('+$reflectionName', reflectable);
432 } 434 }
433 } 435 }
434 } 436 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698