Source/core/layout/LayoutObject.cpp - Issue 1299323005: blink: Add backdrop-filter support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1299323005: blink: Add backdrop-filter support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: removed some todos Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/css3/filters/backdrop-filter-rendering.html ('K') | « Source/core/layout/LayoutObject.h ('k') | Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutObject.cpp

diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp

index 28c61e1fc62b67b095b35bab84d089161fb73d33..699300108431bdbe4f8b794f0a5fb9faa0395217 100644

--- a/Source/core/layout/LayoutObject.cpp

+++ b/Source/core/layout/LayoutObject.cpp

@@ -1700,6 +1700,13 @@ StyleDifference LayoutObject::adjustStyleDifference(StyleDifference diff) const

diff.setNeedsPaintInvalidationLayer();

}

+ // If backdrop filter changed, and the layer does not paint into its own separate backing or it paints with filters, then we need to invalidate paints.

+ if (diff.backdropFilterChanged() && hasLayer()) {

+ DeprecatedPaintLayer* layer = toLayoutBoxModelObject(this)->layer();

+ if (!layer->hasStyleDeterminedDirectCompositingReasons() || layer->paintsWithBackdropFilters())

+ diff.setNeedsPaintInvalidationLayer();

+ }

if (diff.textOrColorChanged() && !diff.needsPaintInvalidation()) {

if (style()->hasBorder() || style()->hasOutline()

|| (isText() && !toLayoutText(this)->isAllCollapsibleWhitespace()))