Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: content/renderer/media/media_stream_dependency_factory.cc

Issue 129923002: Implements MediaStreamVideoSource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_dependency_factory.cc
diff --git a/content/renderer/media/media_stream_dependency_factory.cc b/content/renderer/media/media_stream_dependency_factory.cc
index 8d4fe56bdd811ccc2d6f4a1c6a07fbb25044fdb0..e67134cd2ccb323c02cf9c3203357cfc4df30f84 100644
--- a/content/renderer/media/media_stream_dependency_factory.cc
+++ b/content/renderer/media/media_stream_dependency_factory.cc
@@ -614,6 +614,28 @@ bool MediaStreamDependencyFactory::RemoveNativeMediaStreamTrack(
return false;
}
+blink::WebMediaStreamTrack
+ MediaStreamDependencyFactory::CreateMediaStreamVideoTrack(
perkj_chrome 2014/01/10 13:07:00 I am not sure this belong here. The dependency fac
Ronghua Wu (Left Chromium) 2014/01/11 01:22:58 Not sure where else should I put this though. The
+ const std::string& id) {
+ blink::WebMediaStreamTrack track;
+ blink::WebMediaStreamSource source;
+ blink::WebString idw(base::UTF8ToUTF16(id));
+ source.initialize(idw, blink::WebMediaStreamSource::TypeVideo, idw);
+ track.initialize(idw, source);
+ return track;
+}
+
+scoped_refptr<webrtc::VideoSourceInterface>
+ MediaStreamDependencyFactory::CreateVideoSource(
perkj_chrome 2014/01/10 13:07:00 Make sure this method is used everywhere in this c
Ronghua Wu (Left Chromium) 2014/01/11 01:22:58 Done.
+ cricket::VideoCapturer* capturer,
+ const blink::WebMediaConstraints& constraints) {
+ RTCMediaConstraints native_constraints(constraints);
+ // The video source takes ownership of |capturer|.
+ scoped_refptr<webrtc::VideoSourceInterface> source =
+ pc_factory_->CreateVideoSource(capturer, &native_constraints).get();
+ return source;
+}
+
bool MediaStreamDependencyFactory::CreatePeerConnectionFactory() {
DCHECK(!pc_factory_.get());
DCHECK(!audio_device_.get());

Powered by Google App Engine
This is Rietveld 408576698