Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic/arm/ic-arm.cc

Issue 1299213002: Cleanup: Remove unncessary leave_frame parameter from stub cache. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ic/arm/stub-cache-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 420 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 DCHECK(!AreAliased(vector, slot, r4, r5, r6, r9)); 431 DCHECK(!AreAliased(vector, slot, r4, r5, r6, r9));
432 Handle<TypeFeedbackVector> dummy_vector = 432 Handle<TypeFeedbackVector> dummy_vector =
433 TypeFeedbackVector::DummyVector(masm->isolate()); 433 TypeFeedbackVector::DummyVector(masm->isolate());
434 int slot_index = dummy_vector->GetIndex( 434 int slot_index = dummy_vector->GetIndex(
435 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot)); 435 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot));
436 __ LoadRoot(vector, Heap::kDummyVectorRootIndex); 436 __ LoadRoot(vector, Heap::kDummyVectorRootIndex);
437 __ mov(slot, Operand(Smi::FromInt(slot_index))); 437 __ mov(slot, Operand(Smi::FromInt(slot_index)));
438 438
439 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 439 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
440 Code::ComputeHandlerFlags(Code::LOAD_IC)); 440 Code::ComputeHandlerFlags(Code::LOAD_IC));
441 masm->isolate()->stub_cache()->GenerateProbe( 441 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::KEYED_LOAD_IC, flags,
442 masm, Code::KEYED_LOAD_IC, flags, false, receiver, key, r4, r5, r6, r9); 442 receiver, key, r4, r5, r6, r9);
443 // Cache miss. 443 // Cache miss.
444 GenerateMiss(masm); 444 GenerateMiss(masm);
445 445
446 // Do a quick inline probe of the receiver's dictionary, if it 446 // Do a quick inline probe of the receiver's dictionary, if it
447 // exists. 447 // exists.
448 __ bind(&probe_dictionary); 448 __ bind(&probe_dictionary);
449 // r3: elements 449 // r3: elements
450 __ ldr(r0, FieldMemOperand(receiver, HeapObject::kMapOffset)); 450 __ ldr(r0, FieldMemOperand(receiver, HeapObject::kMapOffset));
451 __ ldrb(r0, FieldMemOperand(r0, Map::kInstanceTypeOffset)); 451 __ ldrb(r0, FieldMemOperand(r0, Map::kInstanceTypeOffset));
452 GenerateGlobalInstanceTypeCheck(masm, r0, &slow); 452 GenerateGlobalInstanceTypeCheck(masm, r0, &slow);
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 Handle<TypeFeedbackVector> dummy_vector = 701 Handle<TypeFeedbackVector> dummy_vector =
702 TypeFeedbackVector::DummyVector(masm->isolate()); 702 TypeFeedbackVector::DummyVector(masm->isolate());
703 int slot_index = dummy_vector->GetIndex( 703 int slot_index = dummy_vector->GetIndex(
704 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot)); 704 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot));
705 __ LoadRoot(vector, Heap::kDummyVectorRootIndex); 705 __ LoadRoot(vector, Heap::kDummyVectorRootIndex);
706 __ mov(slot, Operand(Smi::FromInt(slot_index))); 706 __ mov(slot, Operand(Smi::FromInt(slot_index)));
707 } 707 }
708 708
709 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 709 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
710 Code::ComputeHandlerFlags(Code::STORE_IC)); 710 Code::ComputeHandlerFlags(Code::STORE_IC));
711 masm->isolate()->stub_cache()->GenerateProbe( 711 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags,
712 masm, Code::STORE_IC, flags, false, receiver, key, r3, r4, r5, r6); 712 receiver, key, r3, r4, r5, r6);
713 // Cache miss. 713 // Cache miss.
714 __ b(&miss); 714 __ b(&miss);
715 715
716 // Extra capacity case: Check if there is extra capacity to 716 // Extra capacity case: Check if there is extra capacity to
717 // perform the store and update the length. Used for adding one 717 // perform the store and update the length. Used for adding one
718 // element to the array by writing to array[array.length]. 718 // element to the array by writing to array[array.length].
719 __ bind(&extra); 719 __ bind(&extra);
720 // Condition code from comparing key and array length is still available. 720 // Condition code from comparing key and array length is still available.
721 __ b(ne, &slow); // Only support writing to writing to array[array.length]. 721 __ b(ne, &slow); // Only support writing to writing to array[array.length].
722 // Check for room in the elements backing store. 722 // Check for room in the elements backing store.
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 Register receiver = StoreDescriptor::ReceiverRegister(); 763 Register receiver = StoreDescriptor::ReceiverRegister();
764 Register name = StoreDescriptor::NameRegister(); 764 Register name = StoreDescriptor::NameRegister();
765 DCHECK(receiver.is(r1)); 765 DCHECK(receiver.is(r1));
766 DCHECK(name.is(r2)); 766 DCHECK(name.is(r2));
767 DCHECK(StoreDescriptor::ValueRegister().is(r0)); 767 DCHECK(StoreDescriptor::ValueRegister().is(r0));
768 768
769 // Get the receiver from the stack and probe the stub cache. 769 // Get the receiver from the stack and probe the stub cache.
770 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 770 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
771 Code::ComputeHandlerFlags(Code::STORE_IC)); 771 Code::ComputeHandlerFlags(Code::STORE_IC));
772 772
773 masm->isolate()->stub_cache()->GenerateProbe( 773 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags,
774 masm, Code::STORE_IC, flags, false, receiver, name, r3, r4, r5, r6); 774 receiver, name, r3, r4, r5, r6);
775 775
776 // Cache miss: Jump to runtime. 776 // Cache miss: Jump to runtime.
777 GenerateMiss(masm); 777 GenerateMiss(masm);
778 } 778 }
779 779
780 780
781 void StoreIC::GenerateMiss(MacroAssembler* masm) { 781 void StoreIC::GenerateMiss(MacroAssembler* masm) {
782 StoreIC_PushArgs(masm); 782 StoreIC_PushArgs(masm);
783 783
784 // Perform tail call to the entry. 784 // Perform tail call to the entry.
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
901 patcher.EmitCondition(ne); 901 patcher.EmitCondition(ne);
902 } else { 902 } else {
903 DCHECK(Assembler::GetCondition(branch_instr) == ne); 903 DCHECK(Assembler::GetCondition(branch_instr) == ne);
904 patcher.EmitCondition(eq); 904 patcher.EmitCondition(eq);
905 } 905 }
906 } 906 }
907 } // namespace internal 907 } // namespace internal
908 } // namespace v8 908 } // namespace v8
909 909
910 #endif // V8_TARGET_ARCH_ARM 910 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ic/arm/stub-cache-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698