Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 12992004: chromeos: Remove dead power manager code. (Closed)

Created:
7 years, 9 months ago by Daniel Erat
Modified:
7 years, 9 months ago
CC:
chromium-reviews, derat+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Remove dead power manager code. This removes the OutputObserver class, which used to listen for ScreenPowerSetSignal D-Bus signals from powerd and pass the requests on to OutputConfigurator. This is now handled by DisplayPowerServiceProvider, which serves as an endpoint for SetDisplayPower method calls. It also removes the timestamp argument from HandleUserActivity method calls to powerd. powerd no longer uses (or reads, for that matter) the argument. BUG=chromium:221391 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189809

Patch Set 1 #

Patch Set 2 : merge and fix gmock call #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -135 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/chromeos/power/output_observer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/chromeos/power/output_observer.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/chromeos/power/user_activity_notifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/mock_power_manager_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_manager_client.h View 1 2 chunks +1 line, -10 lines 0 comments Download
M chromeos/dbus/power_manager_client.cc View 1 4 chunks +3 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Erat
7 years, 9 months ago (2013-03-21 18:16:51 UTC) #1
stevenjb
lgtm
7 years, 9 months ago (2013-03-21 18:32:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/12992004/1
7 years, 9 months ago (2013-03-21 18:55:44 UTC) #3
commit-bot: I haz the power
Presubmit check for 12992004-1 failed and returned exit status 1. INFO:root:Found 8 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-21 18:55:50 UTC) #4
Daniel Erat
TBR ben for chrome/chrome_browser_chromeos.gypi
7 years, 9 months ago (2013-03-21 19:10:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/12992004/1
7 years, 9 months ago (2013-03-21 19:38:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/12992004/21001
7 years, 9 months ago (2013-03-21 22:11:40 UTC) #7
Daniel Erat
7 years, 9 months ago (2013-03-22 15:02:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r189809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698