Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1299153002: Revert of Implement extended master secret in tlslite (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
Reviewers:
nharper, davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement extended master secret in tlslite (patchset #3 id:40001 of https://codereview.chromium.org/1283373002/ ) Reason for revert: Broke SSLClientSocketOpenSSLClientAuthTest.SendGoodCert on Android Tests and Android Tests (dbg): http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/21769 http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/29668 Original issue's description: > Implement extended master secret in tlslite > > BUG=467312 > > Committed: https://crrev.com/8a61fc9eaf016b964a6adc42dd2288f9193f70cd > Cr-Commit-Position: refs/heads/master@{#344031} TBR=davidben@chromium.org,nharper@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467312 Committed: https://crrev.com/8688bb977f9d4a6c9fbccfbac86ad578a4de8e72 Cr-Commit-Position: refs/heads/master@{#344147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -247 lines) Patch
M third_party/tlslite/README.chromium View 1 chunk +1 line, -3 lines 0 comments Download
D third_party/tlslite/patches/extended_master_secret.patch View 1 chunk +0 lines, -197 lines 0 comments Download
M third_party/tlslite/tlslite/constants.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/tlslite/tlslite/handshakesettings.py View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/tlslite/tlslite/mathtls.py View 1 chunk +7 lines, -11 lines 0 comments Download
M third_party/tlslite/tlslite/messages.py View 4 chunks +0 lines, -7 lines 0 comments Download
M third_party/tlslite/tlslite/tlsconnection.py View 7 chunks +6 lines, -17 lines 0 comments Download
M third_party/tlslite/tlslite/tlsrecordlayer.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of Implement extended master secret in tlslite
5 years, 4 months ago (2015-08-19 04:35:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299153002/1
5 years, 4 months ago (2015-08-19 04:35:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 04:38:14 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 04:39:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8688bb977f9d4a6c9fbccfbac86ad578a4de8e72
Cr-Commit-Position: refs/heads/master@{#344147}

Powered by Google App Engine
This is Rietveld 408576698