Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1299023002: [turbofan] Fix stack->stack double moves for pushing on ia32 and x64. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix stack->stack double moves for pushing on ia32 and x64. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/d0bacc61e6930d97888bf747a76bcfa329995847 Cr-Commit-Position: refs/heads/master@{#30235}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -6 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/instruction.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 2 chunks +54 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 4 months ago (2015-08-18 17:08:21 UTC) #1
Michael Starzinger
LGTM.
5 years, 4 months ago (2015-08-18 17:17:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299023002/20001
5 years, 4 months ago (2015-08-18 17:19:16 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 18:22:01 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 18:22:15 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0bacc61e6930d97888bf747a76bcfa329995847
Cr-Commit-Position: refs/heads/master@{#30235}

Powered by Google App Engine
This is Rietveld 408576698