Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1299013003: Update SkOpts namespaces. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update SkOpts namespaces. portable -> default, and everyone gets an sk_ prefix. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/b2a327094f2b9a072fddfd440481b1c0a8b0bc80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M src/core/SkOpts.cpp View 2 chunks +17 lines, -17 lines 0 comments Download
M src/opts/SkOpts_neon.cpp View 2 chunks +15 lines, -15 lines 0 comments Download
M src/opts/SkOpts_sse41.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/opts/SkOpts_ssse3.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299013003/1
5 years, 4 months ago (2015-08-18 16:47:11 UTC) #2
mtklein_C
5 years, 4 months ago (2015-08-18 16:51:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 16:55:06 UTC) #6
djsollen
lgtm
5 years, 4 months ago (2015-08-18 16:58:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299013003/1
5 years, 4 months ago (2015-08-18 16:59:53 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 17:00:33 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b2a327094f2b9a072fddfd440481b1c0a8b0bc80

Powered by Google App Engine
This is Rietveld 408576698