Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12990003: Bump trace viewer dep to r223. (Closed)

Created:
7 years, 9 months ago by dsinclair
Modified:
7 years, 9 months ago
Reviewers:
nduca
CC:
chromium-reviews
Visibility:
Public.

Description

Bump trace viewer dep to r223. This pulls in the continuous tracing code from trace-viewer. BUG=156025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dsinclair
7 years, 9 months ago (2013-03-21 17:59:56 UTC) #1
nduca
LGTM
7 years, 9 months ago (2013-03-21 19:17:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/12990003/1
7 years, 9 months ago (2013-03-21 19:58:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/12990003/1
7 years, 9 months ago (2013-03-22 02:30:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/12990003/1
7 years, 9 months ago (2013-03-22 13:48:30 UTC) #5
dsinclair
Committed patchset #1 manually as r189856 (presubmit successful).
7 years, 9 months ago (2013-03-22 18:27:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/12990003/1
7 years, 9 months ago (2013-03-22 19:18:22 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-22 19:18:27 UTC) #8
Message was sent while issue was closed. 
Failed to apply patch for DEPS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file DEPS
  Hunk #1 FAILED at 73.
  1 out of 1 hunk FAILED -- saving rejects to file DEPS.rej

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
f8faa80664e267e417d0297317a1ddcdbc4623e3..4df8d9e1513becf468f81f1602b7e874c7ce065c
100644
--- a/DEPS
+++ b/DEPS
@@ -73,7 +73,7 @@ deps = {
     (Var("googlecode_url") % "angleproject") + "/trunk@2001",
 
   "src/third_party/trace-viewer":
-    (Var("googlecode_url") % "trace-viewer") + "/trunk@220",
+    (Var("googlecode_url") % "trace-viewer") + "/trunk@223",
 
   # Note that this is *not* where we check out WebKit -- this just
   # puts some extra files into place for the real WebKit checkout to

Powered by Google App Engine
This is Rietveld 408576698